commit 7ad258361357e4b49c33ff39ce8abdcdf747c702
author Simon Pilgrim <llvm-dev@redking.me.uk> Tue Nov 05 15:58:04 2019 +0000
committer Simon Pilgrim <llvm-dev@redking.me.uk> Tue Nov 05 17:08:08 2019 +0000
tree c25645a30982cb85c0afd4ef0f7c99e561d35ee7
parent bc496677d0ecc24e4372b714849b5ecc8636b3a8

[MachineOutliner] Reduce scope of variable and stop duplicate getMF() calls. NFCI.

llvm/lib/CodeGen/MachineOutliner.cpp

diff --git a/llvm/lib/CodeGen/MachineOutliner.cpp b/llvm/lib/CodeGen/MachineOutliner.cpp
index c4c3f2f..9c61bce 100644
--- a/llvm/lib/CodeGen/MachineOutliner.cpp
+++ b/llvm/lib/CodeGen/MachineOutliner.cpp
@@ -904,10 +904,10 @@
   /// Return a DISubprogram for OF if one exists, and null otherwise. Helper
   /// function for remark emission.
   DISubprogram *getSubprogramOrNull(const OutlinedFunction &OF) {
-    DISubprogram *SP;
     for (const Candidate &C : OF.Candidates)
-      if (C.getMF() && (SP = C.getMF()->getFunction().getSubprogram()))
-        return SP;
+      if (MachineFunction *MF = C.getMF())
+        if (DISubprogram *SP = MF->getFunction().getSubprogram())
+          return SP;
     return nullptr;
   }