commit 7f37775e56e24770edb30205c9cddae23a7754b4
author Rafael Espindola <rafael.espindola@gmail.com> Tue Sep 01 20:30:52 2015 +0000
committer Rafael Espindola <rafael.espindola@gmail.com> Tue Sep 01 20:30:52 2015 +0000
tree b5940d6c1a18960b8f8619d54abd9c37d9249d4f
parent 45a98fffa5e2a82470e173f7c145643afdbae0d8

Every symbol now has an Elf_Sym. Simplify. NFC.

llvm-svn: 246581

lld/ELF/Writer.cpp

diff --git a/lld/ELF/Writer.cpp b/lld/ELF/Writer.cpp
index 91a0bf5..7faa71d 100644
--- a/lld/ELF/Writer.cpp
+++ b/lld/ELF/Writer.cpp
@@ -298,43 +298,36 @@
   for (auto &P : Table.getSymbols()) {
     StringRef Name = P.first;
     Symbol *Sym = P.second;
+    SymbolBody *Body = Sym->Body;
+    const Elf_Sym &InputSym = cast<ELFSymbolBody<ELFT>>(Body)->Sym;
 
     auto *ESym = reinterpret_cast<Elf_Sym *>(Buf);
     ESym->st_name = Builder.getOffset(Name);
-    SymbolBody *Body = Sym->Body;
 
     const SectionChunk<ELFT> *Section = nullptr;
-    const Elf_Sym *InputSym = nullptr;
     OutputSection<ELFT> *Out = nullptr;
 
     switch (Body->kind()) {
-    case SymbolBody::DefinedRegularKind: {
-      auto *Def = cast<DefinedRegular<ELFT>>(Body);
-      InputSym = &Def->Sym;
-      Section = &Def->Section;
+    case SymbolBody::DefinedRegularKind:
+      Section = &cast<DefinedRegular<ELFT>>(Body)->Section;
       break;
-    }
     case SymbolBody::DefinedCommonKind:
-      InputSym = &cast<ELFSymbolBody<ELFT>>(Body)->Sym;
       Out = BSSSec;
       break;
     case SymbolBody::UndefinedKind:
       assert(Body->isWeak() && "Should be defined by now");
     case SymbolBody::DefinedAbsoluteKind:
-      InputSym = &cast<ELFSymbolBody<ELFT>>(Body)->Sym;
       break;
     }
 
-    if (InputSym) {
-      uint8_t Type = InputSym->getType();
-      uint8_t Binding = InputSym->getBinding();
-      ESym->setBindingAndType(Binding, Type);
-      ESym->st_size = InputSym->st_size;
-      ESym->st_other = InputSym->st_other;
-      if (InputSym->isAbsolute()) {
-        ESym->st_shndx = SHN_ABS;
-        ESym->st_value = InputSym->st_value;
-      }
+    uint8_t Type = InputSym.getType();
+    uint8_t Binding = InputSym.getBinding();
+    ESym->setBindingAndType(Binding, Type);
+    ESym->st_size = InputSym.st_size;
+    ESym->st_other = InputSym.st_other;
+    if (InputSym.isAbsolute()) {
+      ESym->st_shndx = SHN_ABS;
+      ESym->st_value = InputSym.st_value;
     }
 
     if (Section)
@@ -348,7 +341,7 @@
       if (auto *C = dyn_cast<DefinedCommon<ELFT>>(Body))
         VA += C->OffsetInBSS;
       else
-        VA += InputSym->st_value;
+        VA += InputSym.st_value;
       ESym->st_value = VA;
     }