commit 8087ca21605a2edcb16cfbded03db8813ea84ef4
author Greg Clayton <gclayton@apple.com> Fri Oct 08 04:20:14 2010 +0000
committer Greg Clayton <gclayton@apple.com> Fri Oct 08 04:20:14 2010 +0000
tree 3f76ae2486d7a0793f73ad95156875bc07bbcbca
parent bb6a881862cd05e05bc5abaff9d321fa741de133

Added mutex protection to the Symtab class.

Added a new SortOrder enumeration and hooked it up to the "image dump symtab"
command so we can dump symbol tables in the original order, sorted by address, 
or sorted by name.

llvm-svn: 116049

lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp

diff --git a/lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp b/lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
index 5b66ef8..4d7ce7f 100644
--- a/lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
+++ b/lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
@@ -647,6 +647,8 @@
     Symtab *symbol_table = new Symtab(this);
     m_symtab_ap.reset(symbol_table);
 
+    Mutex::Locker locker (symbol_table->GetMutex ());
+    
     if (!(ParseSectionHeaders() && GetSectionHeaderStringTable()))
         return symbol_table;
 
@@ -658,7 +660,7 @@
         {
             const ELFSectionHeader &symtab_section = *I;
             user_id_t section_id = SectionIndex(I);
-            ParseSymbolTable(symbol_table, symtab_section, section_id);
+            ParseSymbolTable (symbol_table, symtab_section, section_id);
         }
     }
 
@@ -685,7 +687,7 @@
         section_list->Dump(s, NULL, true);
     Symtab *symtab = GetSymtab();
     if (symtab)
-        symtab->Dump(s, NULL);
+        symtab->Dump(s, NULL, lldb::eSortOrderNone);
     s->EOL();
     DumpDependentModules(s);
     s->EOL();

lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp

diff --git a/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp b/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
index 666fde4..a4141c0 100644
--- a/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
+++ b/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
@@ -206,6 +206,7 @@
     if (m_symtab_ap.get() == NULL)
     {
         m_symtab_ap.reset(new Symtab(this));
+        Mutex::Locker locker (m_symtab_ap->GetMutex());
         ParseSymtab (true);
     }
     return m_symtab_ap.get();
@@ -1348,7 +1349,7 @@
         m_sections_ap->Dump(s, NULL, true);
 
     if (m_symtab_ap.get())
-        m_symtab_ap->Dump(s, NULL);
+        m_symtab_ap->Dump(s, NULL, eSortOrderNone);
 }