commit 81df9eb0f2ce55ff7bdd6061344ea7cb4104d5dc
author Richard Smith <richard-llvm@metafoo.co.uk> Mon Oct 02 22:43:36 2017 +0000
committer Richard Smith <richard-llvm@metafoo.co.uk> Mon Oct 02 22:43:36 2017 +0000
tree 5a6aac07dec2edfb7d649e405ad68499172da0e4
parent 7b8928c729ac1a0bb1c00268a7fa0c9e92886e15

PR33839: Fix -Wunused handling for structured binding declarations.

We warn about a structured binding declaration being unused only if none of its
bindings are used.

llvm-svn: 314733

clang/lib/Sema/SemaDeclCXX.cpp

diff --git a/clang/lib/Sema/SemaDeclCXX.cpp b/clang/lib/Sema/SemaDeclCXX.cpp
index 82e112b..5d9a39c 100644
--- a/clang/lib/Sema/SemaDeclCXX.cpp
+++ b/clang/lib/Sema/SemaDeclCXX.cpp
@@ -829,7 +829,10 @@
   NamedDecl *New =
       ActOnVariableDeclarator(S, D, DC, TInfo, Previous,
                               MultiTemplateParamsArg(), AddToScope, Bindings);
-  CurContext->addHiddenDecl(New);
+  if (AddToScope) {
+    S->AddDecl(New);
+    CurContext->addHiddenDecl(New);
+  }
 
   if (isInOpenMPDeclareTargetContext())
     checkDeclIsAllowedInOpenMPTarget(nullptr, New);