[PM] Normalize FIXMEs for missing PreserveCFG to have the same wording.
llvm-svn: 273974
diff --git a/llvm/lib/Transforms/InstCombine/InstructionCombining.cpp b/llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
index 2d3ff83..c25199d 100644
--- a/llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
+++ b/llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
@@ -3111,7 +3111,7 @@
return PreservedAnalyses::all();
// Mark all the analyses that instcombine updates as preserved.
- // FIXME: Need a way to preserve CFG analyses here!
+ // FIXME: This should also 'preserve the CFG'.
PreservedAnalyses PA;
PA.preserve<DominatorTreeAnalysis>();
return PA;
diff --git a/llvm/lib/Transforms/Scalar/ADCE.cpp b/llvm/lib/Transforms/Scalar/ADCE.cpp
index 89e1c50..0eed024 100644
--- a/llvm/lib/Transforms/Scalar/ADCE.cpp
+++ b/llvm/lib/Transforms/Scalar/ADCE.cpp
@@ -149,8 +149,7 @@
if (!aggressiveDCE(F))
return PreservedAnalyses::all();
- // FIXME: ADCE should also 'preserve the CFG'.
- // The new pass manager has currently no way to do it.
+ // FIXME: This should also 'preserve the CFG'.
auto PA = PreservedAnalyses();
PA.preserve<GlobalsAA>();
return PA;
diff --git a/llvm/lib/Transforms/Scalar/BDCE.cpp b/llvm/lib/Transforms/Scalar/BDCE.cpp
index e2587f9..4f6225f4c 100644
--- a/llvm/lib/Transforms/Scalar/BDCE.cpp
+++ b/llvm/lib/Transforms/Scalar/BDCE.cpp
@@ -74,8 +74,7 @@
if (!bitTrackingDCE(F, DB))
return PreservedAnalyses::all();
- // FIXME: BDCE should also 'preserve the CFG'.
- // The new pass manager has currently no way to do it.
+ // FIXME: This should also 'preserve the CFG'.
auto PA = PreservedAnalyses();
PA.preserve<GlobalsAA>();
return PA;
diff --git a/llvm/lib/Transforms/Scalar/Float2Int.cpp b/llvm/lib/Transforms/Scalar/Float2Int.cpp
index dfe50fb..7aa6dc6 100644
--- a/llvm/lib/Transforms/Scalar/Float2Int.cpp
+++ b/llvm/lib/Transforms/Scalar/Float2Int.cpp
@@ -532,7 +532,7 @@
if (!runImpl(F))
return PreservedAnalyses::all();
else {
- //FIXME: setPreservesCFG is not currently supported in the new PM.
+ // FIXME: This should also 'preserve the CFG'.
PreservedAnalyses PA;
PA.preserve<GlobalsAA>();
return PA;
diff --git a/llvm/lib/Transforms/Scalar/IndVarSimplify.cpp b/llvm/lib/Transforms/Scalar/IndVarSimplify.cpp
index 3538784..542cf38 100644
--- a/llvm/lib/Transforms/Scalar/IndVarSimplify.cpp
+++ b/llvm/lib/Transforms/Scalar/IndVarSimplify.cpp
@@ -2233,8 +2233,7 @@
if (!IVS.run(&L))
return PreservedAnalyses::all();
- // FIXME: once we have an equivalent of AU.setPreservesCFG() in the
- // new pass manager, we should use that here.
+ // FIXME: This should also 'preserve the CFG'.
return getLoopPassPreservedAnalyses();
}
diff --git a/llvm/lib/Transforms/Scalar/MergedLoadStoreMotion.cpp b/llvm/lib/Transforms/Scalar/MergedLoadStoreMotion.cpp
index eb67aea..0a86920 100644
--- a/llvm/lib/Transforms/Scalar/MergedLoadStoreMotion.cpp
+++ b/llvm/lib/Transforms/Scalar/MergedLoadStoreMotion.cpp
@@ -595,8 +595,7 @@
if (!Impl.run(F, MD, AA))
return PreservedAnalyses::all();
- // FIXME: This pass should also 'preserve the CFG'.
- // The new pass manager has currently no way to do it.
+ // FIXME: This should also 'preserve the CFG'.
PreservedAnalyses PA;
PA.preserve<GlobalsAA>();
PA.preserve<MemoryDependenceAnalysis>();
diff --git a/llvm/lib/Transforms/Scalar/Reassociate.cpp b/llvm/lib/Transforms/Scalar/Reassociate.cpp
index b09ed24..b930a8f 100644
--- a/llvm/lib/Transforms/Scalar/Reassociate.cpp
+++ b/llvm/lib/Transforms/Scalar/Reassociate.cpp
@@ -2226,8 +2226,7 @@
ValueRankMap.clear();
if (MadeChange) {
- // FIXME: Reassociate should also 'preserve the CFG'.
- // The new pass manager has currently no way to do it.
+ // FIXME: This should also 'preserve the CFG'.
auto PA = PreservedAnalyses();
PA.preserve<GlobalsAA>();
return PA;
diff --git a/llvm/lib/Transforms/Utils/LCSSA.cpp b/llvm/lib/Transforms/Utils/LCSSA.cpp
index 029164d..2510869 100644
--- a/llvm/lib/Transforms/Utils/LCSSA.cpp
+++ b/llvm/lib/Transforms/Utils/LCSSA.cpp
@@ -340,8 +340,7 @@
if (!formLCSSAOnAllLoops(&LI, DT, SE))
return PreservedAnalyses::all();
- // FIXME: There is no setPreservesCFG in the new PM. When that becomes
- // available, it should be used here.
+ // FIXME: This should also 'preserve the CFG'.
PreservedAnalyses PA;
PA.preserve<BasicAA>();
PA.preserve<GlobalsAA>();
diff --git a/llvm/lib/Transforms/Utils/Mem2Reg.cpp b/llvm/lib/Transforms/Utils/Mem2Reg.cpp
index d26a603..1419254 100644
--- a/llvm/lib/Transforms/Utils/Mem2Reg.cpp
+++ b/llvm/lib/Transforms/Utils/Mem2Reg.cpp
@@ -59,11 +59,7 @@
if (!promoteMemoryToRegister(F, DT, AC))
return PreservedAnalyses::all();
- // FIXME: This pass should preserve the CFG.
- // There's currently no way to do it in the new PM.
- // In the old PM this pass preserved a fair amount of "orthogonal"
- // transformation passes. This concept has no sense in the new PM,
- // therefore we don't preserve them here.
+ // FIXME: This should also 'preserve the CFG'.
return PreservedAnalyses::none();
}