Finesse 'idempotent operations' analyzer issues to include the opcode of the binary operator for clearer error reporting. Also remove the 'Idempotent operation' prefix in messages; it's redundant since the bug type is the same.
llvm-svn: 109527
diff --git a/clang/test/Analysis/constant-folding.c b/clang/test/Analysis/constant-folding.c
index 5a7e6be..b1ca3ee 100644
--- a/clang/test/Analysis/constant-folding.c
+++ b/clang/test/Analysis/constant-folding.c
@@ -18,10 +18,10 @@
}
void testSelfOperations (int a) {
- if ((a|a) != a) WARN; // expected-warning{{idempotent operation}}
- if ((a&a) != a) WARN; // expected-warning{{idempotent operation}}
- if ((a^a) != 0) WARN; // expected-warning{{idempotent operation}}
- if ((a-a) != 0) WARN; // expected-warning{{idempotent operation}}
+ if ((a|a) != a) WARN; // expected-warning{{Both operands to '|' always have the same value}}
+ if ((a&a) != a) WARN; // expected-warning{{Both operands to '&' always have the same value}}
+ if ((a^a) != 0) WARN; // expected-warning{{Both operands to '^' always have the same value}}
+ if ((a-a) != 0) WARN; // expected-warning{{Both operands to '-' always have the same value}}
}
void testIdempotent (int a) {
@@ -68,5 +68,5 @@
if (b!=a) WARN;
if (b>a) WARN;
if (b<a) WARN;
- if (b-a) WARN; // expected-warning{{idempotent operation}}
+ if (b-a) WARN; // expected-warning{{Both operands to '-' always have the same value}}
}