commit 84be998497669c555eb5d0221d73b5d8434dbdd4
author Richard Smith <richard-llvm@metafoo.co.uk> Thu Jun 06 23:24:18 2019 +0000
committer Richard Smith <richard-llvm@metafoo.co.uk> Thu Jun 06 23:24:18 2019 +0000
tree 8614de65124bc19c5481b429d10c943a6a659709
parent dcf17ded66cda437987b5e983f6177cbcc5fa8b6

Factor out duplicated code building a MemberExpr and marking it
referenced.

This reinstates r362563, reverted in r362597.

llvm-svn: 362757

clang/lib/Sema/SemaExprCXX.cpp

diff --git a/clang/lib/Sema/SemaExprCXX.cpp b/clang/lib/Sema/SemaExprCXX.cpp
index c42d272..2f7e4a0 100644
--- a/clang/lib/Sema/SemaExprCXX.cpp
+++ b/clang/lib/Sema/SemaExprCXX.cpp
@@ -7189,15 +7189,12 @@
     }
   }
 
-  MemberExpr *ME = MemberExpr::Create(
-      Context, Exp.get(), /*IsArrow=*/false, SourceLocation(),
-      NestedNameSpecifierLoc(), SourceLocation(), Method,
-      DeclAccessPair::make(FoundDecl, FoundDecl->getAccess()),
-      DeclarationNameInfo(), /*TemplateArgs=*/nullptr, Context.BoundMemberTy,
-      VK_RValue, OK_Ordinary);
-  if (HadMultipleCandidates)
-    ME->setHadMultipleCandidates(true);
-  MarkMemberReferenced(ME);
+  MemberExpr *ME =
+      BuildMemberExpr(Exp.get(), /*IsArrow=*/false, SourceLocation(),
+                      NestedNameSpecifierLoc(), SourceLocation(), Method,
+                      DeclAccessPair::make(FoundDecl, FoundDecl->getAccess()),
+                      HadMultipleCandidates, DeclarationNameInfo(),
+                      Context.BoundMemberTy, VK_RValue, OK_Ordinary);
 
   QualType ResultType = Method->getReturnType();
   ExprValueKind VK = Expr::getValueKindForType(ResultType);