[clang-tidy] Avoid inconsistent notes in readability-container-size-empty
When a warning is issued in a template instantiation, the check would previously
use template arguments in a note, which would result in inconsistent or
duplicate warnings (depending on how deduplication was done). This patch removes
template arguments from the note.
llvm-svn: 347652
diff --git a/clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp b/clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp
index 60a153a..97f9eb7 100644
--- a/clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp
+++ b/clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp
@@ -213,6 +213,14 @@
}
const auto *Container = Result.Nodes.getNodeAs<NamedDecl>("container");
+ if (const auto *CTS = dyn_cast<ClassTemplateSpecializationDecl>(Container)) {
+ // The definition of the empty() method is the same for all implicit
+ // instantiations. In order to avoid duplicate or inconsistent warnings
+ // (depending on how deduplication is done), we use the same class name
+ // for all implicit instantiations of a template.
+ if (CTS->getSpecializationKind() == TSK_ImplicitInstantiation)
+ Container = CTS->getSpecializedTemplate();
+ }
const auto *Empty = Result.Nodes.getNodeAs<FunctionDecl>("empty");
diag(Empty->getLocation(), "method %0::empty() defined here",