Make llvm-dwarfdump exit with non-zero exit code if error was occured.
llvm-svn: 240729
diff --git a/llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp b/llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp
index c1cb021..db3fcf6 100644
--- a/llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp
+++ b/llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp
@@ -69,22 +69,27 @@
clEnumValN(DIDT_StrOffsetsDwo, "str_offsets.dwo", ".debug_str_offsets.dwo"),
clEnumValEnd));
+static int ReturnValue = EXIT_SUCCESS;
+
+static bool error(StringRef Filename, std::error_code EC) {
+ if (!EC)
+ return false;
+ errs() << Filename << ": " << EC.message() << "\n";
+ ReturnValue = EXIT_FAILURE;
+ return true;
+}
+
static void DumpInput(StringRef Filename) {
ErrorOr<std::unique_ptr<MemoryBuffer>> BuffOrErr =
MemoryBuffer::getFileOrSTDIN(Filename);
-
- if (std::error_code EC = BuffOrErr.getError()) {
- errs() << Filename << ": " << EC.message() << "\n";
+ if (error(Filename, BuffOrErr.getError()))
return;
- }
std::unique_ptr<MemoryBuffer> Buff = std::move(BuffOrErr.get());
ErrorOr<std::unique_ptr<ObjectFile>> ObjOrErr =
ObjectFile::createObjectFile(Buff->getMemBufferRef());
- if (std::error_code EC = ObjOrErr.getError()) {
- errs() << Filename << ": " << EC.message() << '\n';
+ if (error(Filename, ObjOrErr.getError()))
return;
- }
ObjectFile &Obj = *ObjOrErr.get();
std::unique_ptr<DIContext> DICtx(new DWARFContextInMemory(Obj));
@@ -109,5 +114,5 @@
std::for_each(InputFilenames.begin(), InputFilenames.end(), DumpInput);
- return 0;
+ return ReturnValue;
}