[analyzer] CastValueChecker: Correctly model results of based-to-derived casts.
Our SVal hierarchy doesn't allow modeling pointer casts as no-op. The
pointer type is instead encoded into the pointer object. Defer to our
usual pointer casting facility, SValBuilder::evalBinOp().
Fixes a crash.
llvm-svn: 369729
diff --git a/clang/test/Analysis/cast-value-logic.cpp b/clang/test/Analysis/cast-value-logic.cpp
index 5317728..221ae7f 100644
--- a/clang/test/Analysis/cast-value-logic.cpp
+++ b/clang/test/Analysis/cast-value-logic.cpp
@@ -19,7 +19,11 @@
virtual double area();
};
class Triangle : public Shape {};
-class Circle : public Shape {};
+class Circle : public Shape {
+public:
+ ~Circle();
+};
+class SuspiciouslySpecificCircle : public Circle {};
} // namespace clang
using namespace llvm;
@@ -149,4 +153,10 @@
return S->area();
return S->area() / 2;
}
+
+void test_delete_crash() {
+ extern Circle *makeCircle();
+ Shape *S = makeCircle();
+ delete cast<SuspiciouslySpecificCircle>(S);
+}
} // namespace crashes
diff --git a/clang/test/Analysis/cast-value-notes.cpp b/clang/test/Analysis/cast-value-notes.cpp
index f92ba90..a0eaeae 100644
--- a/clang/test/Analysis/cast-value-notes.cpp
+++ b/clang/test/Analysis/cast-value-notes.cpp
@@ -123,8 +123,7 @@
void evalZeroParamNonNullReturn(const Shape &S) {
const auto *C = S.castAs<Circle>();
- // expected-note@-1 {{'S' is a 'Circle'}}
- // expected-note@-2 {{'C' initialized here}}
+ // expected-note@-1 {{'C' initialized here}}
(void)(1 / !C);
// expected-note@-1 {{'C' is non-null}}