commit 86c9831bb40d2c50c36b748b08a75860c4640875
author Martin Storsjö <martin@martin.st> Thu Dec 19 13:57:47 2019 +0200
committer Martin Storsjö <martin@martin.st> Mon Dec 23 12:13:48 2019 +0200
tree c1f5165b8061fe847e89d255d963c3b4aa12ca93
parent cc522bc4e3e5e3c46ef34c94c64980957880f738

[ItaniumCXXABI] Don't mark an extern_weak init function as dso_local on windows

Since 6bf108d77a3c, we try to not mark extern_weak symbols as
dso_local, to allow using COFF stubs for references to those symbols
(as the symbol may be missing, resolving to an absolute address zero,
outside of the current DSO).

Differential Revision: https://reviews.llvm.org/D71716

clang/lib/CodeGen/ItaniumCXXABI.cpp

diff --git a/clang/lib/CodeGen/ItaniumCXXABI.cpp b/clang/lib/CodeGen/ItaniumCXXABI.cpp
index 9256142..cf3074d 100644
--- a/clang/lib/CodeGen/ItaniumCXXABI.cpp
+++ b/clang/lib/CodeGen/ItaniumCXXABI.cpp
@@ -2684,7 +2684,9 @@
 
     if (Init) {
       Init->setVisibility(Var->getVisibility());
-      Init->setDSOLocal(Var->isDSOLocal());
+      // Don't mark an extern_weak function DSO local on windows.
+      if (!CGM.getTriple().isOSWindows() || !Init->hasExternalWeakLinkage())
+        Init->setDSOLocal(Var->isDSOLocal());
     }
 
     llvm::LLVMContext &Context = CGM.getModule().getContext();