commit 896b2c53ba2331091e0a0bac17083dcc245e4569
author Frederic Riss <friss@apple.com> Tue Dec 16 20:21:34 2014 +0000
committer Frederic Riss <friss@apple.com> Tue Dec 16 20:21:34 2014 +0000
tree b11560c662163b4629cbfe5e992fd844c3b4ab28
parent 5d3280c7a7fd9ff33631bf696a383cb758505230

[dsymutil] Avoid calling getStringTableData() for each symbol. NFC.

llvm-svn: 224360

llvm/tools/dsymutil/MachODebugMapParser.cpp

diff --git a/llvm/tools/dsymutil/MachODebugMapParser.cpp b/llvm/tools/dsymutil/MachODebugMapParser.cpp
index 9a5e545..c67e90c 100644
--- a/llvm/tools/dsymutil/MachODebugMapParser.cpp
+++ b/llvm/tools/dsymutil/MachODebugMapParser.cpp
@@ -36,6 +36,7 @@
   object::OwningBinary<object::MachOObjectFile> MainOwningBinary;
   /// Map of the binary symbol addresses.
   StringMap<uint64_t> MainBinarySymbolAddresses;
+  StringRef MainBinaryStrings;
   /// The constructed DebugMap.
   std::unique_ptr<DebugMap> Result;
 
@@ -121,6 +122,7 @@
   loadMainBinarySymbols();
   Result = make_unique<DebugMap>();
   const auto &MainBinary = *MainOwningBinary.getBinary();
+  MainBinaryStrings = MainBinary.getStringTableData();
   for (const SymbolRef &Symbol : MainBinary.symbols()) {
     const DataRefImpl &DRI = Symbol.getRawDataRefImpl();
     if (MainBinary.is64Bit())
@@ -142,8 +144,7 @@
   if (!(Type & MachO::N_STAB))
     return;
 
-  const MachOObjectFile &MachOBinary = *MainOwningBinary.getBinary();
-  const char *Name = &MachOBinary.getStringTableData().data()[StringIndex];
+  const char *Name = &MainBinaryStrings.data()[StringIndex];
 
   // An N_OSO entry represents the start of a new object file description.
   if (Type == MachO::N_OSO)