commit 8db11a4f1ceff5b8c70cd1838db20c7983033bb7
author Rafael Espindola <rafael.espindola@gmail.com> Tue Sep 05 23:00:51 2017 +0000
committer Rafael Espindola <rafael.espindola@gmail.com> Tue Sep 05 23:00:51 2017 +0000
tree cca46b22345d290c77ab5d622d5f305738d2d09a
parent c22c699882c8bf602063b43d6da3abb55dd30868

Fix a use after free.

llvm-svn: 312590

llvm/tools/obj2yaml/elf2yaml.cpp

diff --git a/llvm/tools/obj2yaml/elf2yaml.cpp b/llvm/tools/obj2yaml/elf2yaml.cpp
index 3f33fbd..b603cb8 100644
--- a/llvm/tools/obj2yaml/elf2yaml.cpp
+++ b/llvm/tools/obj2yaml/elf2yaml.cpp
@@ -80,11 +80,11 @@
   if (!NameOrErr)
     return NameOrErr;
   StringRef Name = *NameOrErr;
-  std::string Ret = Name;
+  std::string &Ret = SectionNames[SecIndex];
+  Ret = Name;
   while (!UsedSectionNames.insert(Ret).second)
     Ret = (Name + to_string(++Suffix)).str();
-  SectionNames[SecIndex] = Ret;
-  return SectionNames[SecIndex];
+  return Ret;
 }
 
 template <class ELFT> ErrorOr<ELFYAML::Object *> ELFDumper<ELFT>::dump() {