commit 8e781a888ae6d27b6ab1c06790fad8a88d5b72ae
author Kostya Serebryany <kcc@google.com> Sun Sep 18 04:52:23 2016 +0000
committer Kostya Serebryany <kcc@google.com> Sun Sep 18 04:52:23 2016 +0000
tree da0cd6683c4beeb8e7b499854f2b38ac0bad153b
parent 1bdaa20b01de28054015003203e77105f490dba2

[libFuzzer] use 'if guard' instead of 'if guard >= 0' with trace-pc; change the guard type to intptr_t; use separate array for 8-bit counters

llvm-svn: 281845

llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp

diff --git a/llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp b/llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp
index 3c137c9..a2755ad 100644
--- a/llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp
+++ b/llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp
@@ -223,7 +223,7 @@
   Function *SanCovTraceGepFunction;
   Function *SanCovTraceSwitchFunction;
   InlineAsm *EmptyAsm;
-  Type *IntptrTy, *Int64Ty, *Int64PtrTy;
+  Type *IntptrTy, *IntptrPtrTy, *Int64Ty, *Int64PtrTy;
   Module *CurModule;
   LLVMContext *C;
   const DataLayout *DL;
@@ -243,6 +243,7 @@
   DL = &M.getDataLayout();
   CurModule = &M;
   IntptrTy = Type::getIntNTy(*C, DL->getPointerSizeInBits());
+  IntptrPtrTy = PointerType::getUnqual(IntptrTy);
   Type *VoidTy = Type::getVoidTy(*C);
   IRBuilder<> IRB(*C);
   Type *Int8PtrTy = PointerType::getUnqual(IRB.getInt8Ty());
@@ -293,7 +294,7 @@
   SanCovTracePC = checkSanitizerInterfaceFunction(
       M.getOrInsertFunction(SanCovTracePCName, VoidTy, nullptr));
   SanCovTracePCGuard = checkSanitizerInterfaceFunction(M.getOrInsertFunction(
-      SanCovTracePCGuardName, VoidTy, Int64PtrTy, nullptr));
+      SanCovTracePCGuardName, VoidTy, IntptrPtrTy, nullptr));
   SanCovTraceEnter = checkSanitizerInterfaceFunction(
       M.getOrInsertFunction(SanCovTraceEnterName, VoidTy, Int32PtrTy, nullptr));
   SanCovTraceBB = checkSanitizerInterfaceFunction(
@@ -355,15 +356,16 @@
     GlobalVariable *Bounds[2];
     const char *Prefix[2] = {"__start_", "__stop_"};
     for (int i = 0; i < 2; i++) {
-      Bounds[i] = new GlobalVariable(M, Int64PtrTy, false,
+      Bounds[i] = new GlobalVariable(M, IntptrPtrTy, false,
                                      GlobalVariable::ExternalLinkage, nullptr,
                                      Prefix[i] + SectionName);
       Bounds[i]->setVisibility(GlobalValue::HiddenVisibility);
     }
     std::tie(CtorFunc, std::ignore) = createSanitizerCtorAndInitFunctions(
         M, SanCovModuleCtorName, SanCovTracePCGuardInitName,
-        {Int64PtrTy, Int64PtrTy}, {IRB.CreatePointerCast(Bounds[0], Int64PtrTy),
-                                 IRB.CreatePointerCast(Bounds[1], Int64PtrTy)});
+        {IntptrPtrTy, IntptrPtrTy},
+        {IRB.CreatePointerCast(Bounds[0], IntptrPtrTy),
+         IRB.CreatePointerCast(Bounds[1], IntptrPtrTy)});
 
     appendToGlobalCtors(M, CtorFunc, SanCtorAndDtorPriority);
 
@@ -669,13 +671,13 @@
         Constant::getNullValue(Int64Ty), "__sancov_guard." + F.getName());
     // TODO: add debug into to GuardVar.
     GuardVar->setSection(SanCovTracePCGuardSection);
-    auto GuardPtr = IRB.CreatePointerCast(GuardVar, Int64PtrTy);
+    auto GuardPtr = IRB.CreatePointerCast(GuardVar, IntptrPtrTy);
     if (!UseCalls) {
       auto GuardLoad = IRB.CreateLoad(GuardPtr);
       GuardLoad->setAtomic(AtomicOrdering::Monotonic);
       GuardLoad->setAlignment(8);
       SetNoSanitizeMetadata(GuardLoad);  // Don't instrument with e.g. asan.
-      auto Cmp = IRB.CreateICmpSGE(
+      auto Cmp = IRB.CreateICmpNE(
           GuardLoad, Constant::getNullValue(GuardLoad->getType()));
       auto Ins = SplitBlockAndInsertIfThen(
           Cmp, &*IP, false, MDBuilder(*C).createBranchWeights(1, 100000));