[LoopRotate] Fix incorrect SCEV invalidation in loop rotation
LoopRotate only invalidates innermost loops while the changes that it makes may
also affert any of this parents. With patch rL329047, SCEV becomes much smarter
about calculation of exit counts for outer loops, so we cannot assume that they are
not affected.
Differential Revision: https://reviews.llvm.org/D45945
llvm-svn: 330582
diff --git a/llvm/lib/Transforms/Utils/LoopRotationUtils.cpp b/llvm/lib/Transforms/Utils/LoopRotationUtils.cpp
index d96c101..d2a2e40 100644
--- a/llvm/lib/Transforms/Utils/LoopRotationUtils.cpp
+++ b/llvm/lib/Transforms/Utils/LoopRotationUtils.cpp
@@ -259,9 +259,10 @@
return false;
// Anything ScalarEvolution may know about this loop or the PHI nodes
- // in its header will soon be invalidated.
+ // in its header will soon be invalidated, and it can also affect its parent
+ // loops as well.
if (SE)
- SE->forgetLoop(L);
+ SE->forgetTopmostLoop(L);
DEBUG(dbgs() << "LoopRotation: rotating "; L->dump());
@@ -476,6 +477,12 @@
DEBUG(dbgs() << "LoopRotation: into "; L->dump());
+#ifndef NDEBUG
+ // Make sure that after all our transforms SE is correct.
+ if (SE)
+ SE->verify();
+#endif
+
++NumRotated;
return true;
}