commit 93431f96a7b14ff03036bae77cc0197fdc98ad52
author Simon Pilgrim <llvm-dev@redking.me.uk> Sat Jan 11 16:00:17 2020 +0000
committer Simon Pilgrim <llvm-dev@redking.me.uk> Sat Jan 11 16:02:23 2020 +0000
tree cb8b07c85fa3e9c2eb3c4e61f7460a0de6f18618
parent d87a76c9dae38b2a1ef63584aee82e74490dc83b

Fix "pointer is null" static analyzer warning. NFCI.

Use cast<> instead of dyn_cast<> since we know that the pointer should be valid (and is dereferenced immediately).

clang/lib/CodeGen/CGStmtOpenMP.cpp

diff --git a/clang/lib/CodeGen/CGStmtOpenMP.cpp b/clang/lib/CodeGen/CGStmtOpenMP.cpp
index 2590b26..f9406a9 100644
--- a/clang/lib/CodeGen/CGStmtOpenMP.cpp
+++ b/clang/lib/CodeGen/CGStmtOpenMP.cpp
@@ -5471,7 +5471,7 @@
       OMPPrivateScope LoopGlobals(CGF);
       if (const auto *LD = dyn_cast<OMPLoopDirective>(&D)) {
         for (const Expr *E : LD->counters()) {
-          const auto *VD = dyn_cast<VarDecl>(cast<DeclRefExpr>(E)->getDecl());
+          const auto *VD = cast<VarDecl>(cast<DeclRefExpr>(E)->getDecl());
           if (!VD->hasLocalStorage() && !CGF.LocalDeclMap.count(VD)) {
             LValue GlobLVal = CGF.EmitLValue(E);
             LoopGlobals.addPrivate(