commit 96d071cd0ccc53bbf94bcd6ed4b52c9006b17e15
author Rafael Espindola <rafael.espindola@gmail.com> Mon Jun 29 23:29:12 2015 +0000
committer Rafael Espindola <rafael.espindola@gmail.com> Mon Jun 29 23:29:12 2015 +0000
tree 23fbac45fb7ee7c71bcb7d3207e4ee6bea0c14b4
parent 79cfd437b5fcb71d4b748831db888c700231c0c4

Don't return error_code from function that never fails.

llvm-svn: 241021

llvm/tools/llvm-objdump/llvm-objdump.cpp

diff --git a/llvm/tools/llvm-objdump/llvm-objdump.cpp b/llvm/tools/llvm-objdump/llvm-objdump.cpp
index 796a79e..6282c51 100644
--- a/llvm/tools/llvm-objdump/llvm-objdump.cpp
+++ b/llvm/tools/llvm-objdump/llvm-objdump.cpp
@@ -212,9 +212,8 @@
 }
 
 bool llvm::RelocAddressLess(RelocationRef a, RelocationRef b) {
-  uint64_t a_addr, b_addr;
-  if (error(a.getOffset(a_addr))) return false;
-  if (error(b.getOffset(b_addr))) return false;
+  uint64_t a_addr = a.getOffset();
+  uint64_t b_addr = b.getOffset();
   return a_addr < b_addr;
 }
 
@@ -890,7 +889,7 @@
         // Print relocation for instruction.
         while (rel_cur != rel_end) {
           bool hidden = false;
-          uint64_t addr;
+          uint64_t addr = rel_cur->getOffset();
           SmallString<16> name;
           SmallString<32> val;
 
@@ -898,7 +897,6 @@
           if (error(rel_cur->getHidden(hidden))) goto skip_print_rel;
           if (hidden) goto skip_print_rel;
 
-          if (error(rel_cur->getOffset(addr))) goto skip_print_rel;
           // Stop when rel_cur's address is past the current instruction.
           if (addr >= Index + Size) break;
           if (error(rel_cur->getTypeName(name))) goto skip_print_rel;
@@ -932,7 +930,7 @@
     outs() << "RELOCATION RECORDS FOR [" << secname << "]:\n";
     for (const RelocationRef &Reloc : Section.relocations()) {
       bool hidden;
-      uint64_t address;
+      uint64_t address = Reloc.getOffset();
       SmallString<32> relocname;
       SmallString<32> valuestr;
       if (error(Reloc.getHidden(hidden)))
@@ -941,8 +939,6 @@
         continue;
       if (error(Reloc.getTypeName(relocname)))
         continue;
-      if (error(Reloc.getOffset(address)))
-        continue;
       if (error(getRelocationValueString(Reloc, valuestr)))
         continue;
       outs() << format(Fmt.data(), address) << " " << relocname << " "