commit 96d071cd0ccc53bbf94bcd6ed4b52c9006b17e15
author Rafael Espindola <rafael.espindola@gmail.com> Mon Jun 29 23:29:12 2015 +0000
committer Rafael Espindola <rafael.espindola@gmail.com> Mon Jun 29 23:29:12 2015 +0000
tree 23fbac45fb7ee7c71bcb7d3207e4ee6bea0c14b4
parent 79cfd437b5fcb71d4b748831db888c700231c0c4

Don't return error_code from function that never fails.

llvm-svn: 241021

llvm/tools/llvm-readobj/COFFDumper.cpp

diff --git a/llvm/tools/llvm-readobj/COFFDumper.cpp b/llvm/tools/llvm-readobj/COFFDumper.cpp
index 0041c7e..1b8bdbe 100644
--- a/llvm/tools/llvm-readobj/COFFDumper.cpp
+++ b/llvm/tools/llvm-readobj/COFFDumper.cpp
@@ -121,9 +121,7 @@
                                           uint64_t Offset, SymbolRef &Sym) {
   const auto &Relocations = RelocMap[Section];
   for (const auto &Relocation : Relocations) {
-    uint64_t RelocationOffset;
-    if (std::error_code EC = Relocation.getOffset(RelocationOffset))
-      return EC;
+    uint64_t RelocationOffset = Relocation.getOffset();
 
     if (RelocationOffset == Offset) {
       Sym = *Relocation.getSymbol();
@@ -805,12 +803,10 @@
 
 void COFFDumper::printRelocation(const SectionRef &Section,
                                  const RelocationRef &Reloc) {
-  uint64_t Offset;
+  uint64_t Offset = Reloc.getOffset();
   uint64_t RelocType;
   SmallString<32> RelocName;
   StringRef SymbolName;
-  if (error(Reloc.getOffset(Offset)))
-    return;
   if (error(Reloc.getType(RelocType)))
     return;
   if (error(Reloc.getTypeName(RelocName)))