commit 9801621616b2eaac6839c144095d8e479385566a
author Nico Weber <nicolasweber@gmx.de> Tue Jul 09 00:02:23 2019 +0000
committer Nico Weber <nicolasweber@gmx.de> Tue Jul 09 00:02:23 2019 +0000
tree 22dc11cf84d52c1e425b906222a1c5a02a187d17
parent c6b5c5b92545d47377e3bd7a15fbdeda4781018d

clang-cl: Port cl.exe's C4659 to clang-cl

Differential Revision: https://reviews.llvm.org/D64349

llvm-svn: 365411

clang/lib/Sema/SemaAttr.cpp

diff --git a/clang/lib/Sema/SemaAttr.cpp b/clang/lib/Sema/SemaAttr.cpp
index e1929e3..8e93188 100644
--- a/clang/lib/Sema/SemaAttr.cpp
+++ b/clang/lib/Sema/SemaAttr.cpp
@@ -403,9 +403,15 @@
   if (Action & PSK_Pop && Stack->Stack.empty())
     Diag(PragmaLocation, diag::warn_pragma_pop_failed) << PragmaName
         << "stack empty";
-  if (SegmentName &&
-      !checkSectionName(SegmentName->getBeginLoc(), SegmentName->getString()))
-    return;
+  if (SegmentName) {
+    if (!checkSectionName(SegmentName->getBeginLoc(), SegmentName->getString()))
+      return;
+
+    if (SegmentName->getString() == ".drectve" &&
+        Context.getTargetInfo().getCXXABI().isMicrosoft())
+      Diag(PragmaLocation, diag::warn_attribute_section_drectve) << PragmaName;
+  }
+
   Stack->Act(PragmaLocation, Action, StackSlotLabel, SegmentName);
 }