commit 98c6bdf2518358a1acade0aafc117c6343e05e4d
author Chris Lattner <sabre@nondot.org> Tue Jul 06 07:11:42 2004 +0000
committer Chris Lattner <sabre@nondot.org> Tue Jul 06 07:11:42 2004 +0000
tree 7335d777b40af923f8fd31a127843455fed07b96
parent 7fd5f0745a6e9649c2d6a9e50566975b8adb9384

Fix a minor bug where we would go into infinite loops on some constants

llvm-svn: 14638

llvm/lib/Transforms/Scalar/InstructionCombining.cpp

diff --git a/llvm/lib/Transforms/Scalar/InstructionCombining.cpp b/llvm/lib/Transforms/Scalar/InstructionCombining.cpp
index fad2730..be1111f 100644
--- a/llvm/lib/Transforms/Scalar/InstructionCombining.cpp
+++ b/llvm/lib/Transforms/Scalar/InstructionCombining.cpp
@@ -846,7 +846,8 @@
 Instruction *InstCombiner::visitRem(BinaryOperator &I) {
   if (I.getType()->isSigned())
     if (Value *RHSNeg = dyn_castNegVal(I.getOperand(1)))
-      if (RHSNeg != I.getOperand(1)) {           // Avoid problems with MININT
+      if (!isa<ConstantSInt>(RHSNeg) ||
+          cast<ConstantSInt>(RHSNeg)->getValue() >= 0) {
         // X % -Y -> X % Y
         AddUsesToWorkList(I);
         I.setOperand(1, RHSNeg);