[driver] The -v option doesn't quoted the command line arguments for historical
reasons. However, it does seems practical to quote strings that need it.
rdar://10221951
llvm-svn: 141202
diff --git a/clang/lib/Driver/Compilation.cpp b/clang/lib/Driver/Compilation.cpp
index 85a5fc9..7a62fa4 100644
--- a/clang/lib/Driver/Compilation.cpp
+++ b/clang/lib/Driver/Compilation.cpp
@@ -70,6 +70,13 @@
return *Entry;
}
+static bool needsQuote(const char *s) {
+ for (const char *c = s; *c; ++c)
+ if (*c == ' ')
+ return true;
+ return false;
+}
+
void Compilation::PrintJob(raw_ostream &OS, const Job &J,
const char *Terminator, bool Quote) const {
if (const Command *C = dyn_cast<Command>(&J)) {
@@ -77,7 +84,7 @@
for (ArgStringList::const_iterator it = C->getArguments().begin(),
ie = C->getArguments().end(); it != ie; ++it) {
OS << ' ';
- if (!Quote) {
+ if (!Quote && !needsQuote(*it)) {
OS << *it;
continue;
}