[clangd] Show better message when we rename macros.
Summary:
Previously, when we rename a macro, we get an error message of "there is
no symbol found".
This patch improves the message of this case (as we don't support macros).
Reviewers: sammccall
Subscribers: ilya-biryukov, MaskRay, jkorous, mgrang, arphaman, kadircet, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D63922
llvm-svn: 364735
diff --git a/clang-tools-extra/clangd/unittests/SourceCodeTests.cpp b/clang-tools-extra/clangd/unittests/SourceCodeTests.cpp
index 9ca6fa1..80cd0db 100644
--- a/clang-tools-extra/clangd/unittests/SourceCodeTests.cpp
+++ b/clang-tools-extra/clangd/unittests/SourceCodeTests.cpp
@@ -9,6 +9,7 @@
#include "Context.h"
#include "Protocol.h"
#include "SourceCode.h"
+#include "TestTU.h"
#include "clang/Format/Format.h"
#include "llvm/Support/Error.h"
#include "llvm/Support/raw_os_ostream.h"
@@ -28,6 +29,8 @@
return arg.line == int(Line) && arg.character == int(Col);
}
+MATCHER_P(MacroName, Name, "") { return arg.Name == Name; }
+
/// A helper to make tests easier to read.
Position position(int line, int character) {
Position Pos;
@@ -404,6 +407,20 @@
}
}
+TEST(SourceCodeTests, GetMacros) {
+ Annotations Code(R"cpp(
+ #define MACRO 123
+ int abc = MA^CRO;
+ )cpp");
+ TestTU TU = TestTU::withCode(Code.code());
+ auto AST = TU.build();
+ auto Loc = getBeginningOfIdentifier(AST, Code.point(),
+ AST.getSourceManager().getMainFileID());
+ auto Result = locateMacroAt(Loc, AST.getPreprocessor());
+ ASSERT_TRUE(Result);
+ EXPECT_THAT(*Result, MacroName("MACRO"));
+}
+
} // namespace
} // namespace clangd
} // namespace clang