commit a62c9d62a32bbbba652b97e21d21e05b4b10fb94
author Eric Liu <ioeric@google.com> Mon Jul 09 18:54:51 2018 +0000
committer Eric Liu <ioeric@google.com> Mon Jul 09 18:54:51 2018 +0000
tree eda38a605fcd5e850a99b0e53f4f865902d44fbf
parent 0566f2352ae5286f73ed5fa2d7cc65933f486aac

[clangd] Make sure macro information exists before increasing usage count.

llvm-svn: 336581

clang-tools-extra/clangd/index/SymbolCollector.cpp

diff --git a/clang-tools-extra/clangd/index/SymbolCollector.cpp b/clang-tools-extra/clangd/index/SymbolCollector.cpp
index 1ad75e1..568dff9 100644
--- a/clang-tools-extra/clangd/index/SymbolCollector.cpp
+++ b/clang-tools-extra/clangd/index/SymbolCollector.cpp
@@ -371,7 +371,6 @@
         Roles & static_cast<unsigned>(index::SymbolRole::Definition)))
     return true;
 
-
   llvm::SmallString<128> USR;
   if (index::generateUSRForMacro(Name->getName(), MI->getDefinitionLoc(), SM,
                                  USR))
@@ -433,11 +432,10 @@
     assert(PP);
     for (const IdentifierInfo *II : ReferencedMacros) {
       llvm::SmallString<128> USR;
-      if (!index::generateUSRForMacro(
-              II->getName(),
-              PP->getMacroDefinition(II).getMacroInfo()->getDefinitionLoc(),
-              PP->getSourceManager(), USR))
-        IncRef(SymbolID(USR));
+      if (const auto *MI = PP->getMacroDefinition(II).getMacroInfo())
+        if (!index::generateUSRForMacro(II->getName(), MI->getDefinitionLoc(),
+                                        PP->getSourceManager(), USR))
+          IncRef(SymbolID(USR));
     }
   }
   ReferencedDecls.clear();