clang-rename: avoid StringRef members in USRLocFindingASTVisitor
Even if this is defined in the .cpp file and only used as part of the
function (so here it's safe), usually storing StringRefs in the class is
dangerous, so don't do so.
Reviewers: cfe-commits, klimek
Differential Revision: http://reviews.llvm.org/D20296
llvm-svn: 269796
diff --git a/clang-tools-extra/clang-rename/USRLocFinder.cpp b/clang-tools-extra/clang-rename/USRLocFinder.cpp
index ca4cf25..9a2356b 100644
--- a/clang-tools-extra/clang-rename/USRLocFinder.cpp
+++ b/clang-tools-extra/clang-rename/USRLocFinder.cpp
@@ -123,9 +123,9 @@
}
// All the locations of the USR were found.
- StringRef USR;
+ const std::string USR;
// Old name that is renamed.
- StringRef PrevName;
+ const std::string PrevName;
std::vector<clang::SourceLocation> LocationsFound;
};
} // namespace