commit ada43f6337e430a38f007778a5ebb7e022bb9c2d
author Rafael Espindola <rafael.espindola@gmail.com> Wed Jun 03 21:30:10 2015 +0000
committer Rafael Espindola <rafael.espindola@gmail.com> Wed Jun 03 21:30:10 2015 +0000
tree 43780cc230c71b04a981338c852ece5620ad59a6
parent ef1e863c2c1a6ea8c8a6bf6138f25f8b2e607584

Record in a MCSymbolELF if it has been used in a relocation.

No functionality change, just saves an on the side map.

llvm-svn: 238979

llvm/include/llvm/MC/MCSymbolELF.h

diff --git a/llvm/include/llvm/MC/MCSymbolELF.h b/llvm/include/llvm/MC/MCSymbolELF.h
index 7ef97ce..22ade52 100644
--- a/llvm/include/llvm/MC/MCSymbolELF.h
+++ b/llvm/include/llvm/MC/MCSymbolELF.h
@@ -18,6 +18,7 @@
   const MCExpr *SymbolSize = nullptr;
 
   mutable unsigned BindingSet : 1;
+  mutable unsigned UsedInReloc : 1;
 
 public:
   MCSymbolELF(const StringMapEntry<bool> *Name, bool isTemporary)
@@ -40,6 +41,9 @@
 
   bool isBindingSet() const { return BindingSet; }
 
+  void setUsedInReloc() const;
+  bool isUsedInReloc() const;
+
   static bool classof(const MCSymbol *S) { return S->isELF(); }
 };
 }

llvm/lib/MC/ELFObjectWriter.cpp

diff --git a/llvm/lib/MC/ELFObjectWriter.cpp b/llvm/lib/MC/ELFObjectWriter.cpp
index bb1b9a5..6165533 100644
--- a/llvm/lib/MC/ELFObjectWriter.cpp
+++ b/llvm/lib/MC/ELFObjectWriter.cpp
@@ -74,8 +74,7 @@
     static uint64_t SymbolValue(const MCSymbol &Sym, const MCAsmLayout &Layout);
     static bool isInSymtab(const MCAsmLayout &Layout, const MCSymbolELF &Symbol,
                            bool Used, bool Renamed);
-    static bool isLocal(const MCSymbol &Symbol, bool IsUsedInReloc,
-                        bool IsSignature);
+    static bool isLocal(const MCSymbolELF &Symbol, bool IsSignature);
 
     /// Helper struct for containing some precomputed information on symbols.
     struct ELFSymbolData {
@@ -100,7 +99,6 @@
     /// The target specific ELF writer instance.
     std::unique_ptr<MCELFObjectTargetWriter> TargetObjectWriter;
 
-    SmallPtrSet<const MCSymbol *, 16> UsedInReloc;
     SmallPtrSet<const MCSymbol *, 16> WeakrefUsedInReloc;
     DenseMap<const MCSymbolELF *, const MCSymbolELF *> Renames;
 
@@ -144,7 +142,6 @@
         : MCObjectWriter(OS, IsLittleEndian), TargetObjectWriter(MOTW) {}
 
     void reset() override {
-      UsedInReloc.clear();
       WeakrefUsedInReloc.clear();
       Renames.clear();
       Relocations.clear();
@@ -716,7 +713,7 @@
     if (const MCSymbol *WeakRef = getWeakRef(*RefA))
       WeakrefUsedInReloc.insert(WeakRef);
     else
-      UsedInReloc.insert(SymA);
+      SymA->setUsedInReloc();
   }
   ELFRelocationEntry Rec(FixupOffset, SymA, Type, Addend);
   Relocations[&FixupSection].push_back(Rec);
@@ -758,15 +755,14 @@
   return true;
 }
 
-bool ELFObjectWriter::isLocal(const MCSymbol &Symbol, bool IsUsedInReloc,
-                              bool IsSignature) {
+bool ELFObjectWriter::isLocal(const MCSymbolELF &Symbol, bool IsSignature) {
   if (Symbol.isExternal())
     return false;
 
   if (Symbol.isDefined())
     return true;
 
-  if (IsUsedInReloc)
+  if (Symbol.isUsedInReloc())
     return false;
 
   return IsSignature;
@@ -802,7 +798,7 @@
   bool HasLargeSectionIndex = false;
   for (const MCSymbol &S : Asm.symbols()) {
     const auto &Symbol = cast<MCSymbolELF>(S);
-    bool Used = UsedInReloc.count(&Symbol);
+    bool Used = Symbol.isUsedInReloc();
     bool WeakrefUsed = WeakrefUsedInReloc.count(&Symbol);
     bool isSignature = RevGroupMap.count(&Symbol);
 
@@ -815,7 +811,7 @@
 
     // Undefined symbols are global, but this is the first place we
     // are able to set it.
-    bool Local = isLocal(Symbol, Used, isSignature);
+    bool Local = isLocal(Symbol, isSignature);
     if (!Local && Symbol.getBinding() == ELF::STB_LOCAL)
       Symbol.setBinding(ELF::STB_GLOBAL);
 

llvm/lib/MC/MCSymbolELF.cpp

diff --git a/llvm/lib/MC/MCSymbolELF.cpp b/llvm/lib/MC/MCSymbolELF.cpp
index cf609e5..f8a90b9 100644
--- a/llvm/lib/MC/MCSymbolELF.cpp
+++ b/llvm/lib/MC/MCSymbolELF.cpp
@@ -77,4 +77,13 @@
   unsigned Other = (getFlags() & (0x3f << ELF_STO_Shift)) >> ELF_STO_Shift;
   return Other;
 }
+
+void MCSymbolELF::setUsedInReloc() const {
+  UsedInReloc = true;
+}
+
+bool MCSymbolELF::isUsedInReloc() const {
+  return UsedInReloc;
+}
+
 }