Make llvm::StringRef to std::string conversions explicit.
This is how it should've been and brings it more in line with
std::string_view. There should be no functional change here.
This is mostly mechanical from a custom clang-tidy check, with a lot of
manual fixups. It uncovers a lot of minor inefficiencies.
This doesn't actually modify StringRef yet, I'll do that in a follow-up.
diff --git a/lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp b/lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp
index f6f2203..4940564 100644
--- a/lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp
+++ b/lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp
@@ -383,9 +383,10 @@
mh->GetValueForKey("filetype")->GetAsInteger()->GetValue();
if (image->HasKey("min_version_os_name")) {
- std::string os_name = image->GetValueForKey("min_version_os_name")
- ->GetAsString()
- ->GetValue();
+ std::string os_name =
+ std::string(image->GetValueForKey("min_version_os_name")
+ ->GetAsString()
+ ->GetValue());
if (os_name == "macosx")
image_infos[i].os_type = llvm::Triple::MacOSX;
else if (os_name == "ios" || os_name == "iphoneos")
@@ -403,9 +404,9 @@
}
if (image->HasKey("min_version_os_sdk")) {
image_infos[i].min_version_os_sdk =
- image->GetValueForKey("min_version_os_sdk")
- ->GetAsString()
- ->GetValue();
+ std::string(image->GetValueForKey("min_version_os_sdk")
+ ->GetAsString()
+ ->GetValue());
}
// Fields that aren't used by DynamicLoaderDarwin so debugserver doesn't