Don't perform an expensive check if it's not necessary.
llvm-svn: 37620
diff --git a/llvm/lib/Transforms/Scalar/GVNPRE.cpp b/llvm/lib/Transforms/Scalar/GVNPRE.cpp
index a2a7743..ef45dbc 100644
--- a/llvm/lib/Transforms/Scalar/GVNPRE.cpp
+++ b/llvm/lib/Transforms/Scalar/GVNPRE.cpp
@@ -329,7 +329,12 @@
lhsValid = true;
break;
}
- lhsValid &= !dependsOnInvoke(BO->getOperand(0));
+
+ // Check for dependency on invoke insts
+ // NOTE: This check is expensive, so don't do it if we
+ // don't have to
+ if (lhsValid)
+ lhsValid = !dependsOnInvoke(BO->getOperand(0));
bool rhsValid = !isa<Instruction>(BO->getOperand(1));
if (!rhsValid)
@@ -339,7 +344,12 @@
rhsValid = true;
break;
}
- rhsValid &= !dependsOnInvoke(BO->getOperand(1));
+
+ // Check for dependency on invoke insts
+ // NOTE: This check is expensive, so don't do it if we
+ // don't have to
+ if (rhsValid)
+ rhsValid = !dependsOnInvoke(BO->getOperand(1));
if (!lhsValid || !rhsValid)
set.erase(BO);