The MSP430Interrupt attribute does have a sema handler (it's in TargetAttributesSema). Added a FIXME about the attribute being nameless when it really does have a valid name, and a comment explaining why we're using the name instead of the attribute kind.
llvm-svn: 196420
diff --git a/clang/include/clang/Basic/Attr.td b/clang/include/clang/Basic/Attr.td
index ff4050d..3f42c2e 100644
--- a/clang/include/clang/Basic/Attr.td
+++ b/clang/include/clang/Basic/Attr.td
@@ -515,9 +515,13 @@
}
def MSP430Interrupt : InheritableAttr, TargetSpecificAttr {
+ // FIXME: this attribute is spelled the same as the ARMInterrupt attribute,
+ // but two attributes cannot currently share the same name because of the
+ // getAttrKind function. However, in this case, the attributes are for
+ // different targets, so sharing the same name but different arguments is a
+ // reasonable design. For now, this attribute will remain having no spelling.
let Spellings = [];
let Args = [UnsignedArgument<"Number">];
- let SemaHandler = 0;
}
def Mips16 : InheritableAttr, TargetSpecificAttr {
diff --git a/clang/lib/Sema/TargetAttributesSema.cpp b/clang/lib/Sema/TargetAttributesSema.cpp
index 1469e12..034e460 100644
--- a/clang/lib/Sema/TargetAttributesSema.cpp
+++ b/clang/lib/Sema/TargetAttributesSema.cpp
@@ -108,6 +108,8 @@
MSP430AttributesSema() { }
bool ProcessDeclAttribute(Scope *scope, Decl *D,
const AttributeList &Attr, Sema &S) const {
+ // Because this attribute has no spelling (see the FIXME in Attr.td as to
+ // why), we must check for the name instead of the attribute kind.
if (Attr.getName()->getName() == "interrupt") {
HandleMSP430InterruptAttr(D, Attr, S);
return true;