commit b5fe855dfbb1c62e9d82b34cd4f000c122e26256
author George Burgess IV <george.burgess.iv@gmail.com> Mon Jun 12 17:44:30 2017 +0000
committer George Burgess IV <george.burgess.iv@gmail.com> Mon Jun 12 17:44:30 2017 +0000
tree c449bf7a17438d16f6443cec81856e0b05d323b0
parent 5e7b7b7503d0e2e2cbd23d9e027ce4670ce57d3a

[Sema] Use the right FoldingSet.

We were doing FindNodeOrInsertPos on SubstTemplateTypeParmPackTypes, so
we should presumably be inserting into SubstTemplateTypeParmPackTypes.

Looks like the FoldingSet API can be tweaked a bit so that we can catch
things like this at compile-time. I'll look into that shortly.

I'm unsure of how to test this; suggestions welcome.

Thanks to Vladimir Voskresensky for bringing this up!

llvm-svn: 305207

clang/lib/AST/ASTContext.cpp

diff --git a/clang/lib/AST/ASTContext.cpp b/clang/lib/AST/ASTContext.cpp
index 62b1968..d06bbf5 100644
--- a/clang/lib/AST/ASTContext.cpp
+++ b/clang/lib/AST/ASTContext.cpp
@@ -3565,7 +3565,7 @@
     = new (*this, TypeAlignment) SubstTemplateTypeParmPackType(Parm, Canon,
                                                                ArgPack);
   Types.push_back(SubstParm);
-  SubstTemplateTypeParmTypes.InsertNode(SubstParm, InsertPos);
+  SubstTemplateTypeParmPackTypes.InsertNode(SubstParm, InsertPos);
   return QualType(SubstParm, 0);  
 }