Produce STV_DEFAULT for symbols in shared libraries.
The spec says:
If a symbol definition with STV_PROTECTED visibility from a shared
object is taken as resolving a reference from an executable or another
shared object, the SHN_UNDEF symbol table entry created has STV_DEFAULT
visibility.
llvm-svn: 265792
diff --git a/lld/ELF/OutputSections.cpp b/lld/ELF/OutputSections.cpp
index 64949f2..24258fe 100644
--- a/lld/ELF/OutputSections.cpp
+++ b/lld/ELF/OutputSections.cpp
@@ -1458,6 +1458,12 @@
}
}
+static uint8_t getSymbolVisibility(SymbolBody *Body) {
+ if (Body->isShared())
+ return STV_DEFAULT;
+ return Body->getVisibility();
+}
+
template <class ELFT>
void SymbolTableSection<ELFT>::writeGlobalSymbols(uint8_t *Buf) {
// Write the internal symbol table contents to the output symbol table
@@ -1473,7 +1479,7 @@
ESym->setBindingAndType(getSymbolBinding(Body), Type);
ESym->st_size = Size;
ESym->st_name = StrOff;
- ESym->setVisibility(Body->getVisibility());
+ ESym->setVisibility(getSymbolVisibility(Body));
ESym->st_value = Body->getVA<ELFT>();
if (const OutputSectionBase<ELFT> *OutSec = getOutputSection(Body))