commit b744ce87fc48cb60d6c79f00bf8c2959579a2f2f
author Malcolm Parsons <malcolm.parsons@gmail.com> Wed Jan 04 17:33:55 2017 +0000
committer Malcolm Parsons <malcolm.parsons@gmail.com> Wed Jan 04 17:33:55 2017 +0000
tree a09813908a283e2388392b44503fe051faaa1039
parent 6cfb5caf0550a656bd06ea9faf415ad4b2aa9790

[clang-tidy] Ignore default arguments in modernize-default-member-init

Summary:
Default member initializers cannot refer to constructor parameters, but modernize-default-member-init was trying to when the default constructor had default arguments.

Change the check to ignore default arguments to the default constructor.

Fixes PR31524.

Reviewers: alexfh, aaron.ballman

Subscribers: cfe-commits, JDevlieghere, Eugene.Zelenko

Differential Revision: https://reviews.llvm.org/D28287

llvm-svn: 290972

clang-tools-extra/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp

diff --git a/clang-tools-extra/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp b/clang-tools-extra/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp
index c8e9204..d0d4c65 100644
--- a/clang-tools-extra/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp
+++ b/clang-tools-extra/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp
@@ -158,7 +158,7 @@
             unaryOperator(anyOf(hasOperatorName("+"), hasOperatorName("-")),
                           hasUnaryOperand(floatLiteral())),
             cxxBoolLiteral(), cxxNullPtrLiteralExpr(), implicitValueInitExpr(),
-            declRefExpr());
+            declRefExpr(to(enumConstantDecl())));
 
   Finder->addMatcher(
       cxxConstructorDecl(