commit b8fb96905dedcb69e89affe341e9ed0a8bf4f5cb
author Daniel Dunbar <daniel@zuster.org> Sat May 23 18:55:58 2009 +0000
committer Daniel Dunbar <daniel@zuster.org> Sat May 23 18:55:58 2009 +0000
tree afdf3484ddfc94cd854d8a8b31372a8fbe0b5b00
parent c1fca9fb3a6c0e0b3b546927c238e85e9a47f33f

Fix use after free, found by Benjamin Kramer.

llvm-svn: 72333

clang/lib/Driver/HostInfo.cpp

diff --git a/clang/lib/Driver/HostInfo.cpp b/clang/lib/Driver/HostInfo.cpp
index fc6b87f..f60d25e 100644
--- a/clang/lib/Driver/HostInfo.cpp
+++ b/clang/lib/Driver/HostInfo.cpp
@@ -79,12 +79,12 @@
 
   assert(memcmp(&getOSName()[0], "darwin", 6) == 0 &&
          "Unknown Darwin platform.");
-  const char *Release = &getOSName()[6];
   bool HadExtra;
-  if (!Driver::GetReleaseVersion(Release, DarwinVersion[0], DarwinVersion[1], 
+  if (!Driver::GetReleaseVersion(&getOSName()[6], 
+                                 DarwinVersion[0], DarwinVersion[1], 
                                  DarwinVersion[2], HadExtra)) {
     D.Diag(clang::diag::err_drv_invalid_darwin_version)
-      << Release;
+      << getOSName();
   }
   
   // We can only call 4.2.1 for now.