commit ba874ad83ed7c482e5da51385a6df0647f3b5c1a
author Jake Ehrlich <jakehehrlich@google.com> Wed Nov 29 00:54:20 2017 +0000
committer Jake Ehrlich <jakehehrlich@google.com> Wed Nov 29 00:54:20 2017 +0000
tree a21d11b9dbc38a987f551cce1ad84bece5b30947
parent 5fb3ad71a2297734589495a558635bb2e84a413b

Reland "Fix vtable not receiving hidden visibility when using push(visibility)"

I had to reland this change in order to make the test work on windows

This change should resolve https://bugs.llvm.org/show_bug.cgi?id=35022

https://reviews.llvm.org/D39627

llvm-svn: 319269

clang/lib/CodeGen/CGDecl.cpp

diff --git a/clang/lib/CodeGen/CGDecl.cpp b/clang/lib/CodeGen/CGDecl.cpp
index 7350af8..04585a8 100644
--- a/clang/lib/CodeGen/CGDecl.cpp
+++ b/clang/lib/CodeGen/CGDecl.cpp
@@ -240,7 +240,7 @@
       getModule(), LTy, Ty.isConstant(getContext()), Linkage, Init, Name,
       nullptr, llvm::GlobalVariable::NotThreadLocal, TargetAS);
   GV->setAlignment(getContext().getDeclAlign(&D).getQuantity());
-  setGlobalVisibility(GV, &D);
+  setGlobalVisibility(GV, &D, ForDefinition);
 
   if (supportsCOMDAT() && GV->isWeakForLinker())
     GV->setComdat(TheModule.getOrInsertComdat(GV->getName()));