commit bf45ecef66988408a61ea68ce43b547fa154934e
author Petr Hosek <phosek@chromium.org> Fri Feb 23 20:10:14 2018 +0000
committer Petr Hosek <phosek@chromium.org> Fri Feb 23 20:10:14 2018 +0000
tree dab7d53c96ca48aa78908e89a3a6d69c7a484f50
parent 425965be0fd7ca9a85d9f305255353d98d4816ab

[Driver] Make -fno-common default for Fuchsia

We never want to generate common symbols on Fuchsia.

Differential Revision: https://reviews.llvm.org/D43545

llvm-svn: 325945

clang/lib/Driver/ToolChains/Clang.cpp

diff --git a/clang/lib/Driver/ToolChains/Clang.cpp b/clang/lib/Driver/ToolChains/Clang.cpp
index c3d032d..e24164b 100644
--- a/clang/lib/Driver/ToolChains/Clang.cpp
+++ b/clang/lib/Driver/ToolChains/Clang.cpp
@@ -1306,6 +1306,8 @@
 static bool isNoCommonDefault(const llvm::Triple &Triple) {
   switch (Triple.getArch()) {
   default:
+    if (Triple.isOSFuchsia())
+      return true;
     return false;
 
   case llvm::Triple::xcore:

clang/test/Driver/fuchsia.c

diff --git a/clang/test/Driver/fuchsia.c b/clang/test/Driver/fuchsia.c
index 72157ac..57dbc73 100644
--- a/clang/test/Driver/fuchsia.c
+++ b/clang/test/Driver/fuchsia.c
@@ -10,6 +10,7 @@
 // CHECK: "-fuse-init-array"
 // CHECK: "-isysroot" "[[SYSROOT:[^"]+]]"
 // CHECK: "-internal-externc-isystem" "[[SYSROOT]]{{/|\\\\}}include"
+// CHECK: "-fno-common"
 // CHECK: {{.*}}ld.lld{{.*}}" "-z" "rodynamic"
 // CHECK: "--sysroot=[[SYSROOT]]"
 // CHECK: "-pie"