Remove buggy PROVIDE-in-output-description command.
With the previous change, it is now obvious that readProvide in
this context appended new commands to a wrong command list.
It was mistakenly adding new commands to the top level.
Thus, all commands inside output section descriptions were
interpreted as they were written on top level.
PROVIDE command naturally requires symbol assignment support
in the output section description. We don't have that one yet.
I removed the implementation because there's no way to fix it now.
We can resurrect the test once we support the symbol assignment
(with a modification to detect errors that we failed to find as
described.)
llvm-svn: 277687
diff --git a/lld/ELF/LinkerScript.cpp b/lld/ELF/LinkerScript.cpp
index 194f4b7..e58b3be 100644
--- a/lld/ELF/LinkerScript.cpp
+++ b/lld/ELF/LinkerScript.cpp
@@ -822,17 +822,11 @@
Cmd->Commands.emplace_back(readInputSectionDescription());
continue;
}
-
- StringRef Tok = next();
- if (Tok == "PROVIDE") {
- Opt.Commands.emplace_back(readProvide(false));
- } else if (Tok == "PROVIDE_HIDDEN") {
- Opt.Commands.emplace_back(readProvide(true));
- } else if (Tok == "SORT") {
+ if (skip("SORT")) {
readSort();
- } else {
- setError("unknown command " + Tok);
+ continue;
}
+ setError("unknown command " + peek());
}
Cmd->Phdrs = readOutputSectionPhdrs();
Cmd->Filler = readOutputSectionFiller();