commit c1edf566b9ba18806c9a69e77db1cc8e57a14c8d
author Mehdi Amini <mehdi.amini@apple.com> Fri Nov 11 04:29:25 2016 +0000
committer Mehdi Amini <mehdi.amini@apple.com> Fri Nov 11 04:29:25 2016 +0000
tree ea1b174a6e594d2b6929f9e4845cc2ba3d9d6f93
parent 41af43092ccc8030bb49cea324d85eecd5ae68a8

Prevent at compile time converting from Error::success() to Expected<T>

This would trigger an assertion at runtime otherwise.

Differential Revision: https://reviews.llvm.org/D26482

llvm-svn: 286562

lldb/source/Commands/CommandObjectDisassemble.cpp

diff --git a/lldb/source/Commands/CommandObjectDisassemble.cpp b/lldb/source/Commands/CommandObjectDisassemble.cpp
index 6273744..0795033 100644
--- a/lldb/source/Commands/CommandObjectDisassemble.cpp
+++ b/lldb/source/Commands/CommandObjectDisassemble.cpp
@@ -231,7 +231,7 @@
     ExecutionContext *execution_context) {
   if (!some_location_specified)
     current_function = true;
-  return Error::success();
+  return Error();
 }
 
 llvm::ArrayRef<OptionDefinition>

lldb/source/Commands/CommandObjectExpression.cpp

diff --git a/lldb/source/Commands/CommandObjectExpression.cpp b/lldb/source/Commands/CommandObjectExpression.cpp
index d98a3ee..ba477cd 100644
--- a/lldb/source/Commands/CommandObjectExpression.cpp
+++ b/lldb/source/Commands/CommandObjectExpression.cpp
@@ -303,7 +303,7 @@
     return Error("as it does not refer to a pointer");
   if (pointee.IsVoidType())
     return Error("as it refers to a pointer to void");
-  return Error::success();
+  return Error();
 }
 
 bool CommandObjectExpression::EvaluateExpression(const char *expr,