commit c3ec337e4db6ee91db5471cb9e4e479d2f6c1d99
author Todd Fiala <tfiala@google.com> Thu Mar 13 18:30:04 2014 +0000
committer Todd Fiala <tfiala@google.com> Thu Mar 13 18:30:04 2014 +0000
tree 9a450f38def1b418ff52e59f9fb38c38986be63e
parent 639f8ea39715fddcac97db525dbe68f85f295221

Since lldb version doesn’t have to be a valid floating point literal, like x.y.z,
the uses of DEBUGSERVER_VERSION_NUM are invalid and have to be removed.

Change by Kuba Ober.

llvm-svn: 203828

lldb/tools/debugserver/source/CMakeLists.txt

diff --git a/lldb/tools/debugserver/source/CMakeLists.txt b/lldb/tools/debugserver/source/CMakeLists.txt
index f437252..d9b4fea 100644
--- a/lldb/tools/debugserver/source/CMakeLists.txt
+++ b/lldb/tools/debugserver/source/CMakeLists.txt
@@ -11,8 +11,7 @@
 endif()
 
 add_definitions(
-  -DDEBUGSERVER_VERSION_NUM=${LLDB_VERSION}
-  -DDEBUGSERVER_VERSION_STR=${LLDB_VERSION}
+  -DDEBUGSERVER_VERSION_STR="${LLDB_VERSION}"
   )
 
 add_library(lldbDebugserverCommon

lldb/tools/debugserver/source/RNBRemote.cpp

diff --git a/lldb/tools/debugserver/source/RNBRemote.cpp b/lldb/tools/debugserver/source/RNBRemote.cpp
index 2f38e49..2d8b366 100644
--- a/lldb/tools/debugserver/source/RNBRemote.cpp
+++ b/lldb/tools/debugserver/source/RNBRemote.cpp
@@ -3805,7 +3805,7 @@
         strm << "name:" DEBUGSERVER_PROGRAM_NAME ";";
     else
         strm << "name:debugserver;";
-    strm << "version:" << DEBUGSERVER_VERSION_NUM << ";";
+    strm << "version:" << DEBUGSERVER_VERSION_STR << ";";
 
     return SendPacket (strm.str());
 }

lldb/tools/debugserver/source/debugserver.cpp

diff --git a/lldb/tools/debugserver/source/debugserver.cpp b/lldb/tools/debugserver/source/debugserver.cpp
index 9fdcceb..c9a6ebb 100644
--- a/lldb/tools/debugserver/source/debugserver.cpp
+++ b/lldb/tools/debugserver/source/debugserver.cpp
@@ -781,7 +781,7 @@
     {
         g_aslmsg = ::asl_new (ASL_TYPE_MSG);
         char asl_key_sender[PATH_MAX];
-        snprintf(asl_key_sender, sizeof(asl_key_sender), "com.apple.%s-%g", DEBUGSERVER_PROGRAM_NAME, DEBUGSERVER_VERSION_NUM);
+        snprintf(asl_key_sender, sizeof(asl_key_sender), "com.apple.%s-%s", DEBUGSERVER_PROGRAM_NAME, DEBUGSERVER_VERSION_STR);
         ::asl_set (g_aslmsg, ASL_KEY_SENDER, asl_key_sender);
     }
 
@@ -1234,9 +1234,9 @@
     // as long as we're dropping remotenub in as a replacement for gdbserver,
     // explicitly note that this is not gdbserver.
 
-    RNBLogSTDOUT ("%s-%g %sfor %s.\n",
+    RNBLogSTDOUT ("%s-%s %sfor %s.\n",
                   DEBUGSERVER_PROGRAM_NAME,
-                  DEBUGSERVER_VERSION_NUM,
+                  DEBUGSERVER_VERSION_STR,
                   compile_options.c_str(),
                   RNB_ARCH);