commit c445d5ddc36cbe5f22baeedaf07ceabaad89a641
author Richard Smith <richard-llvm@metafoo.co.uk> Tue Oct 03 01:58:15 2017 +0000
committer Richard Smith <richard-llvm@metafoo.co.uk> Tue Oct 03 01:58:15 2017 +0000
tree f905ff21d9437c284adcc1e39a264c1fdfafc2a8
parent 03b7b15f8e879b53148279bcf2dcdda5400d355d

R34811: Allow visibilities other than 'default' for VisibleNoLinkage entities.

llvm-svn: 314754

clang/lib/AST/Decl.cpp

diff --git a/clang/lib/AST/Decl.cpp b/clang/lib/AST/Decl.cpp
index df30426..6e5f638 100644
--- a/clang/lib/AST/Decl.cpp
+++ b/clang/lib/AST/Decl.cpp
@@ -817,9 +817,9 @@
     return LinkageInfo::none();
   }
 
-  // If we ended up with non-external linkage, visibility should
+  // If we ended up with non-externally-visible linkage, visibility should
   // always be default.
-  if (LV.getLinkage() != ExternalLinkage)
+  if (!isExternallyVisible(LV.getLinkage()))
     return LinkageInfo(LV.getLinkage(), DefaultVisibility, false);
 
   return LV;

clang/test/CodeGenCXX/visibility-inlines-hidden.cpp

diff --git a/clang/test/CodeGenCXX/visibility-inlines-hidden.cpp b/clang/test/CodeGenCXX/visibility-inlines-hidden.cpp
index 6ea2348..20e4a1f 100644
--- a/clang/test/CodeGenCXX/visibility-inlines-hidden.cpp
+++ b/clang/test/CodeGenCXX/visibility-inlines-hidden.cpp
@@ -162,3 +162,16 @@
     C::g();
   }
 }
+
+namespace PR34811 {
+  template <typename T> void tf() {}
+  
+  // CHECK-LABEL: define linkonce_odr hidden i8* @_ZN7PR348111fEv(
+  inline void *f() {
+    auto l = []() {};
+    // CHECK-LABEL: define linkonce_odr hidden void @_ZN7PR348112tfIZNS_1fEvEUlvE_EEvv(
+    return (void *)&tf<decltype(l)>;
+  }
+  
+  void *p = (void *)f;
+}