[WebAssembly] Add check to ensure symbol VA is only set once. NFC.
Also remove resulting unneeded function.
Differential Revision: https://reviews.llvm.org/D40990
llvm-svn: 320118
diff --git a/lld/wasm/Driver.cpp b/lld/wasm/Driver.cpp
index 2858f68..475682b 100644
--- a/lld/wasm/Driver.cpp
+++ b/lld/wasm/Driver.cpp
@@ -134,17 +134,6 @@
return None;
}
-// Inject a new wasm global into the output binary with the given value.
-// Wasm global are used in relocatable object files to model symbol imports
-// and exports. In the final executable the only use of wasm globals is
-// for the exlicit stack pointer (__stack_pointer).
-static Symbol* addSyntheticGlobal(StringRef Name, int32_t Value) {
- log("injecting global: " + Name);
- Symbol *S = Symtab->addDefinedGlobal(Name);
- S->setVirtualAddress(Value);
- return S;
-}
-
// Inject a new undefined symbol into the link. This will cause the link to
// fail unless this symbol can be found.
static void addSyntheticUndefinedFunction(StringRef Name,
@@ -285,7 +274,7 @@
for (StringRef S : args::getStrings(Args, OPT_undefined))
addSyntheticUndefinedFunction(S, nullptr);
- Config->StackPointerSymbol = addSyntheticGlobal("__stack_pointer", 0);
+ Config->StackPointerSymbol = Symtab->addDefinedGlobal("__stack_pointer");
}
createFiles(Args);