commit c61b834f3166228a2119ca95b32afc1107f38a45
author Rui Ueyama <ruiu@google.com> Wed Feb 28 00:37:03 2018 +0000
committer Rui Ueyama <ruiu@google.com> Wed Feb 28 00:37:03 2018 +0000
tree 0ab576f4ae6a7db763adf35c4eac81815c6e368e
parent caa8e2335fa7c79ddca44867fa6431d6948e55ee

[WebAssembly] Do not use default arguments for SymbolTable.

Differential Revision: https://reviews.llvm.org/D43727

llvm-svn: 326282

lld/wasm/Driver.cpp

diff --git a/lld/wasm/Driver.cpp b/lld/wasm/Driver.cpp
index 52f82dd..e68a7ce 100644
--- a/lld/wasm/Driver.cpp
+++ b/lld/wasm/Driver.cpp
@@ -300,10 +300,10 @@
         "__wasm_call_ctors", &NullSignature, WASM_SYMBOL_VISIBILITY_HIDDEN);
     WasmSym::StackPointer = Symtab->addSyntheticGlobal(
         "__stack_pointer", WASM_SYMBOL_VISIBILITY_HIDDEN, StackPointer);
-    WasmSym::HeapBase = Symtab->addSyntheticDataSymbol("__heap_base");
+    WasmSym::HeapBase = Symtab->addSyntheticDataSymbol("__heap_base", 0);
     WasmSym::DsoHandle = Symtab->addSyntheticDataSymbol(
         "__dso_handle", WASM_SYMBOL_VISIBILITY_HIDDEN);
-    WasmSym::DataEnd = Symtab->addSyntheticDataSymbol("__data_end");
+    WasmSym::DataEnd = Symtab->addSyntheticDataSymbol("__data_end", 0);
 
     if (!Config->Entry.empty())
       EntrySym = Symtab->addUndefinedFunction(Config->Entry, 0, nullptr,

lld/wasm/SymbolTable.h

diff --git a/lld/wasm/SymbolTable.h b/lld/wasm/SymbolTable.h
index d5ea6ca..ac1aa29 100644
--- a/lld/wasm/SymbolTable.h
+++ b/lld/wasm/SymbolTable.h
@@ -49,10 +49,10 @@
   ObjFile *findComdat(StringRef Name) const;
 
   Symbol *addDefinedFunction(StringRef Name, uint32_t Flags, InputFile *File,
-                             InputFunction *Function = nullptr);
+                             InputFunction *Function);
   Symbol *addDefinedData(StringRef Name, uint32_t Flags, InputFile *File,
-                         InputSegment *Segment = nullptr, uint32_t Address = 0,
-                         uint32_t Size = 0);
+                         InputSegment *Segment, uint32_t Address,
+                         uint32_t Size);
   Symbol *addDefinedGlobal(StringRef Name, uint32_t Flags, InputFile *File,
                            InputGlobal *G);
 
@@ -65,12 +65,12 @@
   void addLazy(ArchiveFile *F, const Archive::Symbol *Sym);
   bool addComdat(StringRef Name, ObjFile *);
 
-  DefinedData *addSyntheticDataSymbol(StringRef Name, uint32_t Flags = 0);
+  DefinedData *addSyntheticDataSymbol(StringRef Name, uint32_t Flags);
   DefinedGlobal *addSyntheticGlobal(StringRef Name, uint32_t Flags,
                                     InputGlobal *Global);
   DefinedFunction *addSyntheticFunction(StringRef Name,
                                         const WasmSignature *Type,
-                                        uint32_t Flags = 0);
+                                        uint32_t Flags);
 
 private:
   std::pair<Symbol *, bool> insert(StringRef Name);