commit c67b00c6959d0a7f96c2f0e394e04e582b321558
author Zachary Turner <zturner@google.com> Wed Sep 14 23:00:16 2016 +0000
committer Zachary Turner <zturner@google.com> Wed Sep 14 23:00:16 2016 +0000
tree 1c7527b7925090baf9dc2fa07188ce454e0927a2
parent 620961deb9bc4c0415d56bed9b2fe20391bd2ad2

[pdb] Get rid of Data and RawData in CVType.

The `CVType` had two redundant fields which were confusing and
error-prone to fill out.  By treating member records as a distinct
type from leaf records, we are able to simplify this quite a bit.

Reviewed By: rnk
Differential Revision: https://reviews.llvm.org/D24432

llvm-svn: 281556

llvm/lib/DebugInfo/PDB/Raw/TpiHashing.cpp

diff --git a/llvm/lib/DebugInfo/PDB/Raw/TpiHashing.cpp b/llvm/lib/DebugInfo/PDB/Raw/TpiHashing.cpp
index d08ec96..6c3ddb3 100644
--- a/llvm/lib/DebugInfo/PDB/Raw/TpiHashing.cpp
+++ b/llvm/lib/DebugInfo/PDB/Raw/TpiHashing.cpp
@@ -58,15 +58,15 @@
 }
 
 void TpiHashUpdater::visitKnownRecordImpl(CVType &CVR, ClassRecord &Rec) {
-  CVR.Hash = getTpiHash(Rec, CVR.RawData);
+  CVR.Hash = getTpiHash(Rec, CVR.data());
 }
 
 void TpiHashUpdater::visitKnownRecordImpl(CVType &CVR, EnumRecord &Rec) {
-  CVR.Hash = getTpiHash(Rec, CVR.RawData);
+  CVR.Hash = getTpiHash(Rec, CVR.data());
 }
 
 void TpiHashUpdater::visitKnownRecordImpl(CVType &CVR, UnionRecord &Rec) {
-  CVR.Hash = getTpiHash(Rec, CVR.RawData);
+  CVR.Hash = getTpiHash(Rec, CVR.data());
 }
 
 Error TpiHashVerifier::visitKnownRecord(CVType &CVR, UdtSourceLineRecord &Rec) {
@@ -79,17 +79,17 @@
 }
 
 Error TpiHashVerifier::visitKnownRecord(CVType &CVR, ClassRecord &Rec) {
-  if (getTpiHash(Rec, CVR.RawData) % NumHashBuckets != HashValues[Index])
+  if (getTpiHash(Rec, CVR.data()) % NumHashBuckets != HashValues[Index])
     return errorInvalidHash();
   return Error::success();
 }
 Error TpiHashVerifier::visitKnownRecord(CVType &CVR, EnumRecord &Rec) {
-  if (getTpiHash(Rec, CVR.RawData) % NumHashBuckets != HashValues[Index])
+  if (getTpiHash(Rec, CVR.data()) % NumHashBuckets != HashValues[Index])
     return errorInvalidHash();
   return Error::success();
 }
 Error TpiHashVerifier::visitKnownRecord(CVType &CVR, UnionRecord &Rec) {
-  if (getTpiHash(Rec, CVR.RawData) % NumHashBuckets != HashValues[Index])
+  if (getTpiHash(Rec, CVR.data()) % NumHashBuckets != HashValues[Index])
     return errorInvalidHash();
   return Error::success();
 }