commit c6802b231f9c156162d9394052a56a06f16a930f
author Gabor Horvath <xazax.hun@gmail.com> Mon Aug 12 16:19:39 2019 +0000
committer Gabor Horvath <xazax.hun@gmail.com> Mon Aug 12 16:19:39 2019 +0000
tree e1f1f54369926635047b9e8097328257c30aa4ac
parent 83bbfaa5e4f89942bb62f318fc9e1ef3b70296c9

Fix multiple lifetime warning messages for range based for loop

llvm-svn: 368588

clang/lib/Sema/SemaInit.cpp

diff --git a/clang/lib/Sema/SemaInit.cpp b/clang/lib/Sema/SemaInit.cpp
index 2be4e89..17cfd12 100644
--- a/clang/lib/Sema/SemaInit.cpp
+++ b/clang/lib/Sema/SemaInit.cpp
@@ -7070,8 +7070,11 @@
       // supporting lifetime extension.
       break;
 
-    case IndirectLocalPathEntry::DefaultInit:
     case IndirectLocalPathEntry::VarInit:
+      if (cast<VarDecl>(Path[I].D)->isImplicit())
+        return SourceRange();
+      LLVM_FALLTHROUGH;
+    case IndirectLocalPathEntry::DefaultInit:
       return Path[I].E->getSourceRange();
     }
   }
@@ -7138,7 +7141,7 @@
         return false;
       }
 
-      if (IsGslPtrInitWithGslTempOwner) {
+      if (IsGslPtrInitWithGslTempOwner && DiagLoc.isValid()) {
         Diag(DiagLoc, diag::warn_dangling_lifetime_pointer) << DiagRange;
         return false;
       }