commit c6ff9c349d8f2992ca27dfe82750ec251b44f52f
author Gabor Horvath <xazax.hun@gmail.com> Mon Dec 21 09:43:52 2015 +0000
committer Gabor Horvath <xazax.hun@gmail.com> Mon Dec 21 09:43:52 2015 +0000
tree d19976ba5fed46c6ed396ba49dcfa5e30738b992
parent e72bebaf2d285784068994a7f38e25ca0e1a8d27

Fix a false positive case in ContainerSizeEmpty check (PR25893).

llvm-svn: 256142

clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp

diff --git a/clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp b/clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp
index 87ba314..c8f7bae 100644
--- a/clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp
+++ b/clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp
@@ -126,6 +126,11 @@
         (OpCode == BinaryOperatorKind::BO_LE && Value == 0 && !ContainerIsLHS))
       return;
 
+    // Do not warn for size > 1, 1 < size.
+    if ((OpCode == BinaryOperatorKind::BO_GT && Value == 1 && ContainerIsLHS) ||
+        (OpCode == BinaryOperatorKind::BO_LT && Value == 1 && !ContainerIsLHS))
+      return;
+
     if (OpCode == BinaryOperatorKind::BO_NE && Value == 0)
       Negation = true;
     if ((OpCode == BinaryOperatorKind::BO_GT ||