| commit | cbecfdfefe11ddc11f9c8efbe894c39d64d74f09 | [log] [tgz] |
|---|---|---|
| author | Alexey Bataev <a.bataev@hotmail.com> | Wed Feb 14 17:38:47 2018 +0000 |
| committer | Alexey Bataev <a.bataev@hotmail.com> | Wed Feb 14 17:38:47 2018 +0000 |
| tree | 555e5468fda0e086b665b3c537623afaef07eda7 | |
| parent | 48f671bb2713fba48dc679008121af5c60d611a3 [diff] |
[OpenMP] Fix trailing space when printing pragmas, by Joel. E. Denny
Summary:
-ast-print prints omp pragmas with a trailing space. While this
behavior is likely of little concern to most users, surely it's
unintentional, and it's annoying for some source-level work I'm
pursuing. This patch focuses on omp pragmas, but it also fixes
init_seg and loop hint pragmas because they share implementation.
The testing strategy here is to add usually just one '{{$}}' per
relevant -ast-print test file. This seems to achieve good code
coverage. However, this strategy is probably easy to forget as the
tests evolve. That's probably fine as this fix is far from critical.
The main goal of the testing is to aid the initial review.
This patch also adds a fixme for "#pragma unroll", which prints as
"#pragma unroll (enable)", which is invalid syntax.
Reviewers: ABataev
Reviewed By: ABataev
Subscribers: guansong, cfe-commits
Differential Revision: https://reviews.llvm.org/D43204
llvm-svn: 325145