commit cd9b7779f39203c735162b2e5c7b1da2ca22443e
author Johnny Chen <johnny.chen@apple.com> Tue Oct 12 00:09:25 2010 +0000
committer Johnny Chen <johnny.chen@apple.com> Tue Oct 12 00:09:25 2010 +0000
tree e8f9de039dacca52263c70a0ae71c2096d8b7f3f
parent c56f5b93c5aa238a186400b8ec0dfe5bc00391b0

Avoid using hardcoded line number to break on.  Use the line_number() utility
function to get the line number to break on during setUp().

llvm-svn: 116275

lldb/test/bitfields/TestBitfields.py

diff --git a/lldb/test/bitfields/TestBitfields.py b/lldb/test/bitfields/TestBitfields.py
index b5a2f92..b29b5f9 100644
--- a/lldb/test/bitfields/TestBitfields.py
+++ b/lldb/test/bitfields/TestBitfields.py
@@ -31,14 +31,21 @@
         self.buildDwarf()
         self.bitfields_variable_python()
 
+    def setUp(self):
+        super(BitfieldsTestCase, self).setUp()
+        # Find the line number to break inside main().
+        self.line = line_number('main.c', '// Set break point at this line.')
+
     def bitfields_variable(self):
         """Test 'frame variable ...' on a variable with bitfields."""
         exe = os.path.join(os.getcwd(), "a.out")
         self.runCmd("file " + exe, CURRENT_EXECUTABLE_SET)
 
         # Break inside the main.
-        self.expect("breakpoint set -f main.c -l 42", BREAKPOINT_CREATED,
-            startstr = "Breakpoint created: 1: file ='main.c', line = 42, locations = 1")
+        self.expect("breakpoint set -f main.c -l %d" % self.line,
+                    BREAKPOINT_CREATED,
+            startstr = "Breakpoint created: 1: file ='main.c', line = %d, locations = 1" %
+                        self.line)
 
         self.runCmd("run", RUN_SUCCEEDED)
 
@@ -81,7 +88,7 @@
         target = self.dbg.CreateTarget(exe)
         self.assertTrue(target.IsValid(), VALID_TARGET)
 
-        breakpoint = target.BreakpointCreateByLocation("main.c", 42)
+        breakpoint = target.BreakpointCreateByLocation("main.c", self.line)
         self.assertTrue(breakpoint.IsValid(), VALID_BREAKPOINT)
 
         self.runCmd("run", RUN_SUCCEEDED, setCookie=False)

lldb/test/bitfields/main.c

diff --git a/lldb/test/bitfields/main.c b/lldb/test/bitfields/main.c
index ca73cc0..8d4116b2 100644
--- a/lldb/test/bitfields/main.c
+++ b/lldb/test/bitfields/main.c
@@ -39,6 +39,6 @@
         bits.b7 = i;        //// break $source:$line
     for (i=0; i<(1<<4); i++)
         bits.four = i;      //// break $source:$line
-    return 0;               //// continue
+    return 0;               //// Set break point at this line.
 
 }

lldb/test/lldbtest.py

diff --git a/lldb/test/lldbtest.py b/lldb/test/lldbtest.py
index 915cfd5..97b351c 100644
--- a/lldb/test/lldbtest.py
+++ b/lldb/test/lldbtest.py
@@ -232,7 +232,7 @@
         for i, line in enumerate(f):
             if line.find(string_to_match) != -1:
                 # Found our match.
-                return i
+                return i+1
     return -1        
 
 def pointer_size():