[ARM] Replace development diagnostics with normal DEBUG macro
* Remove the -arm-asm-parser-dev-diags option.
* Use normal DEBUG(dbgs()) printing for the extra development information about
missing diagnostics.
Differential Revision: https://reviews.llvm.org/D39194
llvm-svn: 316423
diff --git a/llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp b/llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp
index 1e6c175..0f31fd2 100644
--- a/llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp
+++ b/llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp
@@ -64,6 +64,8 @@
#include <utility>
#include <vector>
+#define DEBUG_TYPE "asm-parser"
+
using namespace llvm;
namespace {
@@ -85,11 +87,6 @@
static cl::opt<bool> AddBuildAttributes("arm-add-build-attributes",
cl::init(false));
-cl::opt<bool>
-DevDiags("arm-asm-parser-dev-diags", cl::init(false),
- cl::desc("Use extended diagnostics, which include implementation "
- "details useful for development"));
-
enum VectorLaneTy { NoLanes, AllLanes, IndexedLane };
class UnwindContext {
@@ -10200,18 +10197,16 @@
NearMissMessage Message;
Message.Loc = OperandLoc;
- raw_svector_ostream OS(Message.Message);
if (OperandDiag) {
- OS << OperandDiag;
+ Message.Message = OperandDiag;
} else if (I.getOperandClass() == InvalidMatchClass) {
- OS << "too many operands for instruction";
+ Message.Message = "too many operands for instruction";
} else {
- OS << "invalid operand for instruction";
- if (DevDiags) {
- OS << " class" << I.getOperandClass() << ", error "
- << I.getOperandError() << ", opcode "
- << MII.getName(I.getOpcode());
- }
+ Message.Message = "invalid operand for instruction";
+ DEBUG(dbgs() << "Missing diagnostic string for operand class " <<
+ getMatchClassName((MatchClassKind)I.getOperandClass())
+ << I.getOperandClass() << ", error " << I.getOperandError()
+ << ", opcode " << MII.getName(I.getOpcode()) << "\n");
}
NearMissesOut.emplace_back(Message);
break;