| commit | d0e9c167d8a6ab934bfa20ec0b774488176777a8 | [log] [tgz] |
|---|---|---|
| author | Peter Collingbourne <peter@pcc.me.uk> | Tue Sep 05 19:51:38 2017 +0000 |
| committer | Peter Collingbourne <peter@pcc.me.uk> | Tue Sep 05 19:51:38 2017 +0000 |
| tree | 93e9c71a903eb8c81bf4712fa3a6a302af246c0f | |
| parent | 420c4863a932cef3e7cb74fd1bf6cabbf6e5f62b [diff] [blame] |
LTO: Try to open cache files before renaming them. It appears that a potential race between the cache client and the cache pruner that I thought was unlikely actually happened in practice [1]. Try to avoid the race condition by opening the temporary file before renaming it. Do this only on non-Windows platforms because we cannot rename open files on Windows using the sys::fs::rename function. [1] https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_CFI%2F1610%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout Differential Revision: https://reviews.llvm.org/D37410 llvm-svn: 312567
diff --git a/llvm/tools/llvm-lto2/llvm-lto2.cpp b/llvm/tools/llvm-lto2/llvm-lto2.cpp index 1c7038e..bc22b50 100644 --- a/llvm/tools/llvm-lto2/llvm-lto2.cpp +++ b/llvm/tools/llvm-lto2/llvm-lto2.cpp
@@ -296,7 +296,8 @@ return llvm::make_unique<lto::NativeObjectStream>(std::move(S)); }; - auto AddBuffer = [&](size_t Task, std::unique_ptr<MemoryBuffer> MB) { + auto AddBuffer = [&](size_t Task, std::unique_ptr<MemoryBuffer> MB, + StringRef Path) { *AddStream(Task)->OS << MB->getBuffer(); };