Fixed a ton of gcc compile warnings

Removed some unused variables, added some consts, changed some casts
to const_cast. I don't think any of these changes are very
controversial.

Differential Revision: http://reviews.llvm.org/D9674

llvm-svn: 237218
diff --git a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
index 6eb4fbd..814b1ad 100644
--- a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
+++ b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
@@ -4094,18 +4094,18 @@
         if (!child->name)
             continue;
 
-        if (strcmp ((char*)child->name, "library") != 0)
+        if (strcmp ((const char*)child->name, "library") != 0)
             continue;
 
         GDBLoadedModuleInfoList::LoadedModuleInfo module;
 
         for (xmlAttrPtr prop = child->properties; prop; prop=prop->next)
         {
-            if (strcmp ((char*)prop->name, "name") == 0)
+            if (strcmp ((const char*)prop->name, "name") == 0)
                 module.set_name (xmlExGetTextContent (prop));
 
             // the address of the link_map struct.
-            if (strcmp ((char*)prop->name, "lm") == 0)
+            if (strcmp ((const char*)prop->name, "lm") == 0)
             {
                 std::string val = xmlExGetTextContent (prop);
                 if (val.length() > 2)
@@ -4116,7 +4116,7 @@
             }
 
             // the displacement as read from the field 'l_addr' of the link_map struct.
-            if (strcmp ((char*)prop->name, "l_addr") == 0)
+            if (strcmp ((const char*)prop->name, "l_addr") == 0)
             {
                 std::string val = xmlExGetTextContent (prop);
                 if (val.length() > 2)
@@ -4127,7 +4127,7 @@
             }
 
             // the memory address of the libraries PT_DYAMIC section.
-            if (strcmp ((char*)prop->name, "l_ld") == 0)
+            if (strcmp ((const char*)prop->name, "l_ld") == 0)
             {
                 std::string val = xmlExGetTextContent (prop);
                 if (val.length() > 2)