| commit | d8a5c6cf19e7245f0c9d076831ebeabc29d6e174 | [log] [tgz] |
|---|---|---|
| author | George Rimar <grimar@accesssoftek.com> | Mon Mar 11 11:01:24 2019 +0000 |
| committer | George Rimar <grimar@accesssoftek.com> | Mon Mar 11 11:01:24 2019 +0000 |
| tree | 66eb332dd8cc66dd93de98f26e631affdaf6615e | |
| parent | a7cdfd9cb5643b15fcbd885aa73e5c304ffff91b [diff] |
[llvm-objcopy] - Fix --compress-debug-sections when there are relocations. When --compress-debug-sections is given, llvm-objcopy removes the uncompressed sections and adds compressed to the section list. This makes all the pointers to old sections to be outdated. Currently, code already has logic for replacing the target sections of the relocation sections. But we also have to update the relocations by themselves. This fixes https://bugs.llvm.org/show_bug.cgi?id=40885. Differential revision: https://reviews.llvm.org/D58960 llvm-svn: 355821
diff --git a/llvm/test/tools/llvm-objcopy/ELF/Inputs/compress-debug-sections.yaml b/llvm/test/tools/llvm-objcopy/ELF/Inputs/compress-debug-sections.yaml index bb1e9e6..0f9f5a1 100644 --- a/llvm/test/tools/llvm-objcopy/ELF/Inputs/compress-debug-sections.yaml +++ b/llvm/test/tools/llvm-objcopy/ELF/Inputs/compress-debug-sections.yaml
@@ -18,4 +18,15 @@ - Offset: 0x1 Symbol: .debug_foo Type: R_X86_64_32 + - Offset: 0x2 + Symbol: .notdebug_foo + Type: R_X86_64_32 +Symbols: + Global: + - Name: .debug_foo + Type: STT_SECTION + Section: .debug_foo + - Name: .notdebug_foo + Type: STT_SECTION + Section: .notdebug_foo ...
diff --git a/llvm/test/tools/llvm-objcopy/ELF/compress-debug-sections-zlib-gnu.test b/llvm/test/tools/llvm-objcopy/ELF/compress-debug-sections-zlib-gnu.test index 0a360d0..70eb2e8 100644 --- a/llvm/test/tools/llvm-objcopy/ELF/compress-debug-sections-zlib-gnu.test +++ b/llvm/test/tools/llvm-objcopy/ELF/compress-debug-sections-zlib-gnu.test
@@ -57,7 +57,8 @@ # CHECK-FLAGS: Relocations [ # CHECK-FLAGS-NEXT: .rela.debug_foo { -# CHECK-FLAGS-NEXT: 0x1 R_X86_64_32 - 0x0 +# CHECK-FLAGS-NEXT: 0x1 R_X86_64_32 .zdebug_foo 0x0 +# CHECK-FLAGS-NEXT: 0x2 R_X86_64_32 .notdebug_foo 0x0 # CHECK-FLAGS-NEXT: } # CHECK-FLAGS-NEXT: ]
diff --git a/llvm/test/tools/llvm-objcopy/ELF/compress-debug-sections-zlib.test b/llvm/test/tools/llvm-objcopy/ELF/compress-debug-sections-zlib.test index 1e7dfc9..d6c7429 100644 --- a/llvm/test/tools/llvm-objcopy/ELF/compress-debug-sections-zlib.test +++ b/llvm/test/tools/llvm-objcopy/ELF/compress-debug-sections-zlib.test
@@ -57,7 +57,7 @@ # CHECK-FLAGS: Relocations [ # CHECK-FLAGS-NEXT: .rela.debug_foo { -# CHECK-FLAGS-NEXT: 0x1 R_X86_64_32 - 0x0 +# CHECK-FLAGS-NEXT: 0x1 R_X86_64_32 .debug_foo 0x0 +# CHECK-FLAGS-NEXT: 0x2 R_X86_64_32 .notdebug_foo 0x0 # CHECK-FLAGS-NEXT: } # CHECK-FLAGS-NEXT: ] -