Move code to a helper function. NFC.
Part of a patch by Jake Ehrlich!
llvm-svn: 314012
diff --git a/llvm/lib/Object/ArchiveWriter.cpp b/llvm/lib/Object/ArchiveWriter.cpp
index 4586d44..19a46c0 100644
--- a/llvm/lib/Object/ArchiveWriter.cpp
+++ b/llvm/lib/Object/ArchiveWriter.cpp
@@ -277,6 +277,18 @@
return sys::TimePoint<seconds>();
}
+static bool isArchiveSymbol(const object::BasicSymbolRef &S) {
+ uint32_t Symflags = S.getFlags();
+ if (Symflags & object::SymbolRef::SF_FormatSpecific)
+ return false;
+ if (!(Symflags & object::SymbolRef::SF_Global))
+ return false;
+ if (Symflags & object::SymbolRef::SF_Undefined &&
+ !(Symflags & object::SymbolRef::SF_Indirect))
+ return false;
+ return true;
+}
+
// Returns the offset of the first reference to a member offset.
static Expected<unsigned>
writeSymbolTable(raw_fd_ostream &Out, object::Archive::Kind Kind,
@@ -310,13 +322,7 @@
}
for (const object::BasicSymbolRef &S : Obj.symbols()) {
- uint32_t Symflags = S.getFlags();
- if (Symflags & object::SymbolRef::SF_FormatSpecific)
- continue;
- if (!(Symflags & object::SymbolRef::SF_Global))
- continue;
- if (Symflags & object::SymbolRef::SF_Undefined &&
- !(Symflags & object::SymbolRef::SF_Indirect))
+ if (!isArchiveSymbol(S))
continue;
unsigned NameOffset = NameOS.tell();